Skip to content

Allow newline style for MaxChainedCallsOnSameLine #5865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Feb 28, 2023

Fixes #5598

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #5865 (0e54640) into main (f02e12f) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##               main    #5865      +/-   ##
============================================
- Coverage     84.59%   84.59%   -0.01%     
- Complexity     3784     3787       +3     
============================================
  Files           546      546              
  Lines         12943    12949       +6     
  Branches       2273     2274       +1     
============================================
+ Hits          10949    10954       +5     
  Misses          861      861              
- Partials       1133     1134       +1     
Impacted Files Coverage Δ
...ch/detekt/rules/style/MaxChainedCallsOnSameLine.kt 88.37% <87.50%> (-0.82%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cortinico cortinico added this to the 1.23.0 milestone Mar 1, 2023
atulgpt added 2 commits March 13, 2023 20:02
If receiver is `KtDotQualifiedExpression` then use it's function name
for calculation of `callOnNewLine` this allowed rule to be
indifferent to the braces style. If receiver is not
`KtDotQualifiedExpression` then reverted back to its text length
Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BraisGabin BraisGabin merged commit 8507ea5 into detekt:main Apr 4, 2023
@atulgpt atulgpt deleted the fixes-5598 branch April 5, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on MaxChainedCallsOnSameLine
3 participants