Skip to content

Fix checkExhaustiveness for formatting and third party rules#5869

Merged
cortinico merged 1 commit intodetekt:mainfrom
cortinico:nc/checkExhaustiveness-formatting
Mar 3, 2023
Merged

Fix checkExhaustiveness for formatting and third party rules#5869
cortinico merged 1 commit intodetekt:mainfrom
cortinico:nc/checkExhaustiveness-formatting

Conversation

@cortinico
Copy link
Copy Markdown
Member

Fixes #5790

Sadly, I couldn't test this due to how classloading works with our setup.
Perhaps we can merge it and test @TWiStErRob repo against the SNAPSHOT?

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2023

Codecov Report

Merging #5869 (3b58e2b) into main (c6d7acd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #5869   +/-   ##
=========================================
  Coverage     84.57%   84.57%           
+ Complexity     3786     3785    -1     
=========================================
  Files           546      546           
  Lines         12938    12943    +5     
  Branches       2275     2274    -1     
=========================================
+ Hits          10942    10947    +5     
  Misses          862      862           
  Partials       1134     1134           
Impacted Files Coverage Δ
.../detekt/core/config/validation/ConfigValidation.kt 91.93% <ø> (ø)
...e/config/validation/MissingRulesConfigValidator.kt 100.00% <100.00%> (ø)
...osch/detekt/generator/printer/DeprecatedPrinter.kt 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cortinico cortinico merged commit 64c371a into detekt:main Mar 3, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2023

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the Detekt release notes.

Generated by 🚫 dangerJS against 3b58e2b

@BraisGabin BraisGabin added this to the 1.23.0 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config checkExhaustiveness not failing for some missing rules

2 participants