Skip to content

Cleanup detekt-formatting to use detekt's own assertThat function #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

cortinico
Copy link
Member

We do have several tests inside detekt-formatting which are not using io.gitlab.arturbosch.detekt.test.assertThat. This diverges them from the rest of the codebase, I'm cleaning this up a bit.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #5911 (9504fc3) into main (b07acae) will decrease coverage by 0.11%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##               main    #5911      +/-   ##
============================================
- Coverage     84.56%   84.46%   -0.11%     
- Complexity     3782     3784       +2     
============================================
  Files           546      546              
  Lines         12933    12923      -10     
  Branches       2271     2268       -3     
============================================
- Hits          10937    10915      -22     
- Misses          863      877      +14     
+ Partials       1133     1131       -2     
Impacted Files Coverage Δ
...lab/arturbosch/detekt/formatting/FormattingRule.kt 90.56% <88.88%> (-1.50%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cortinico cortinico changed the title Add support for local suppression inside formatting Cleanup detekt-formatting to use detekt's own assertThat function Mar 16, 2023
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Mar 16, 2023
@BraisGabin BraisGabin added this to the 1.23.0 milestone Mar 17, 2023
@cortinico cortinico merged commit 70ae8d3 into detekt:main Mar 17, 2023
@cortinico cortinico deleted the nc/ktlint-test-cleanup branch March 17, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatting housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants