-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print file path report as link file #5921
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5921 +/- ##
=========================================
Coverage 84.46% 84.46%
Complexity 3784 3784
=========================================
Files 546 546
Lines 12923 12923
Branches 2268 2268
=========================================
Hits 10915 10915
Misses 877 877
Partials 1131 1131
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -40,7 +40,7 @@ class OutputFacade( | |||
val filePath = reports[defaultReportMapping(report.id)]?.path | |||
if (filePath != null) { | |||
report.write(filePath, result) | |||
result.add(SimpleNotification("Successfully generated ${report.name} at $filePath")) | |||
result.add(SimpleNotification("Successfully generated ${report.name} at file://$filePath")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you instead call .toURI
here?
https://docs.oracle.com/javase/7/docs/api/java/nio/file/Path.html#toUri()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, will handle it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated @cortinico
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Can you confirm that .toUri
contains the file://
schema? (like can you post a screenshot of the output)
Base on this discussion. This commit will print report path as a link file. So we can click on the report path on our terminal, and will open directly browser / text editor / etc.
Before:

After
