Skip to content

Print file path report as link file#5921

Merged
cortinico merged 1 commit into
detekt:mainfrom
adef145:main
Mar 23, 2023
Merged

Print file path report as link file#5921
cortinico merged 1 commit into
detekt:mainfrom
adef145:main

Conversation

@adef145

@adef145 adef145 commented Mar 19, 2023

Copy link
Copy Markdown
Contributor

Base on this discussion. This commit will print report path as a link file. So we can click on the report path on our terminal, and will open directly browser / text editor / etc.

Before:
WhatsApp Image 2023-03-17 at 9 36 39 PM

After
WhatsApp Image 2023-03-17 at 9 38 25 PM

@codecov

codecov Bot commented Mar 19, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5921 (723401d) into main (f2cdc1b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 723401d differs from pull request most recent head 270b75a. Consider uploading reports for the commit 270b75a to get more accurate results

@@            Coverage Diff            @@
##               main    #5921   +/-   ##
=========================================
  Coverage     84.46%   84.46%           
  Complexity     3784     3784           
=========================================
  Files           546      546           
  Lines         12923    12923           
  Branches       2268     2268           
=========================================
  Hits          10915    10915           
  Misses          877      877           
  Partials       1131     1131           
Impacted Files Coverage Δ
...b/arturbosch/detekt/core/reporting/OutputFacade.kt 86.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

if (filePath != null) {
report.write(filePath, result)
result.add(SimpleNotification("Successfully generated ${report.name} at $filePath"))
result.add(SimpleNotification("Successfully generated ${report.name} at file://$filePath"))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, will handle it..

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated @cortinico

@cortinico cortinico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Can you confirm that .toUri contains the file:// schema? (like can you post a screenshot of the output)

@adef145

adef145 commented Mar 21, 2023

Copy link
Copy Markdown
Contributor Author

Here it is screenshot after update to toUri(). Still print as file://

WhatsApp Image 2023-03-21 at 5 27 18 PM

@cortinico cortinico added this to the 1.23.0 milestone Mar 23, 2023
@cortinico cortinico merged commit 5b8ec97 into detekt:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants