Prevent import statements from counting as references for UnusedPrivateProperty#5942
Merged
BraisGabin merged 1 commit intoMar 27, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5942 +/- ##
=========================================
Coverage 84.48% 84.48%
Complexity 3789 3789
=========================================
Files 546 546
Lines 12935 12937 +2
Branches 2273 2275 +2
=========================================
+ Hits 10928 10930 +2
Misses 877 877
Partials 1130 1130
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
BraisGabin
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5941
Basically ignore import statements when counting references for the purposes of identifying Unused Private Properties.
Also took the opportunity to improve the previous test
package declarations are ignoreda bit.