Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #5954

Closed
wants to merge 1 commit into from
Closed

Update README.md #5954

wants to merge 1 commit into from

Conversation

mjovanc
Copy link
Contributor

@mjovanc mjovanc commented Mar 31, 2023

A similar PR may already be submitted!
Please search among the Pull requests before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Link to relevant issues if possible.

For more information, see the CONTRIBUTING guide.

@github-actions
Copy link

Messages
📖

Thank you very much for making our website better ❤️!

Generated by 🚫 dangerJS against 06c22f4

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #5954 (06c22f4) into main (a3dfea2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #5954   +/-   ##
=========================================
  Coverage     84.48%   84.48%           
  Complexity     3788     3788           
=========================================
  Files           546      546           
  Lines         12937    12937           
  Branches       2275     2275           
=========================================
  Hits          10930    10930           
  Misses          877      877           
  Partials       1130     1130           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@3flex 3flex disabled auto-merge April 1, 2023 20:55
@3flex
Copy link
Member

3flex commented Apr 1, 2023

There are a couple of reasons I don't think we should include this:

  1. This isn't meant to be a complete Gradle build file, it's just to show a few relevant snippets to get started, and adding this at the top makes it a bit noisier.
  2. It uses a star import which is something detekt would warn about.

Can we change the withType<Detekt> to use a fully qualified class instead?

@cortinico
Copy link
Member

There are a couple of reasons I don't think we should include this:

nit: I think we should not have those examples on the README at all. We do have a versioned website and that should be the source of thruth

@mjovanc mjovanc closed this by deleting the head repository Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants