Skip to content

Fix elvis to +/- case in case UnnecessaryParentheses when precedence is unclear #5983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2023
Merged

Fix elvis to +/- case in case UnnecessaryParentheses when precedence is unclear #5983

merged 1 commit into from
Apr 16, 2023

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Apr 11, 2023 •
edited
Loading

Fixes #4495

@github-actions github-actions bot added the rules label Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023 •
edited
Loading

Codecov Report

Merging #5983 (6f31c5c) into main (b925968) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #5983   +/-   ##
=========================================
  Coverage     84.66%   84.66%           
  Complexity     3836     3836           
=========================================
  Files           549      549           
  Lines         13065    13068    +3     
  Branches       2305     2305           
=========================================
+ Hits          11061    11064    +3     
  Misses          868      868           
  Partials       1136     1136
Impacted Files Coverage Δ
...bosch/detekt/rules/style/UnnecessaryParentheses.kt 86.36% <100.00%> (+0.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atulgpt
Fix elvis to +/- case
6f31c5c 
Add tc for elvis to pair
@atulgpt atulgpt mentioned this pull request Apr 11, 2023
Closed
@atulgpt atulgpt changed the title Fix elvis to +/- case Fix elvis to +/- case in case UnnecessaryParentheses when precedence is unclear Apr 11, 2023
@cortinico cortinico added this to the 1.23.0 milestone Apr 12, 2023
@atulgpt
Copy link
Contributor Author

atulgpt commented Apr 13, 2023

Hi, @BraisGabin failing CI seems to be intermittent GitHub API issue

@cortinico cortinico merged commit b4172a6 into detekt:main Apr 16, 2023
@atulgpt atulgpt deleted the fixes-4495 branch April 16, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
rules
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

UnnecessaryParentheses where IDE prompts for clarifying parentheses.
4 participants
@atulgpt @BraisGabin @schalkms @cortinico