Skip to content

Update dependency Gradle to v8.1 #5996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 14, 2023
Merged

Update dependency Gradle to v8.1 #5996

merged 6 commits into from
Apr 14, 2023

Conversation

3flex
Copy link
Member

@3flex 3flex commented Apr 14, 2023

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #5996 (dfb8b9f) into main (ff2f619) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #5996   +/-   ##
=========================================
  Coverage     84.66%   84.66%           
  Complexity     3836     3836           
=========================================
  Files           549      549           
  Lines         13065    13065           
  Branches       2305     2305           
=========================================
  Hits          11061    11061           
  Misses          868      868           
  Partials       1136     1136           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -4,10 +4,6 @@ plugins {
signing
}

tasks.withType<Sign>().configureEach {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@cortinico cortinico added the notable changes Marker for notable changes in the changelog label Apr 14, 2023
@cortinico
Copy link
Member

Do we want this inside 1.23? Feels like yes

@3flex
Copy link
Member Author

3flex commented Apr 14, 2023

I think so. It doesn't directly impact build artifacts; the configuration cache test change is just to align with Gradle's more correct behaviour in 8.1.

The build failure on Java 8 is an issue, I'll investigate. It might actually be a regression in Gradle.

@github-actions
Copy link

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against dfb8b9f

@3flex
Copy link
Member Author

3flex commented Apr 14, 2023

It's not a regression, but an issue that we didn't see previously because of a confluence of reasons that will take me too long to type up.

I've raised gradle/gradle#24765 but in the meantime I've marked the GenerateMavenPom task incompatible with configuration cache, but only on Java 8. That will work around the issue and won't impact most contributors anyway since most will be running Gradle with more modern Java versions.

@3flex 3flex merged commit 4636877 into detekt:main Apr 14, 2023
@TWiStErRob TWiStErRob added this to the 1.23.0 milestone Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build gradle-plugin notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants