Skip to content

Fix redundant ClassOrdering violations using maximum increasing section #6003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2023
Merged

Fix redundant ClassOrdering violations using maximum increasing section #6003

merged 1 commit into from
Apr 29, 2023

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Apr 15, 2023

Fixes #3144

@github-actions github-actions bot added the rules label Apr 15, 2023
@atulgpt atulgpt force-pushed the fixes/3144 branch 2 times, most recently from 257050a to acbcac5 Compare April 15, 2023 11:28
@atulgpt atulgpt changed the title Fixes/3144 Find redundant ClassOrdering violations using maximum increasing section Apr 15, 2023
@atulgpt atulgpt changed the title Find redundant ClassOrdering violations using maximum increasing section Fix redundant ClassOrdering violations using maximum increasing section Apr 15, 2023
@atulgpt
Find maximum length increasing section
079d0ca 
And based on that find the minimal violation
Original implementation comment at detekt#3142 (comment) which suggested the [algo](https://www.geeksforgeeks.org/minimum-insertions-sort-array/) from which this change is derived
@codecov
Copy link

codecov bot commented Apr 15, 2023 •
edited
Loading

Codecov Report

Merging #6003 (acbcac5) into main (b925968) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

❗ Current head acbcac5 differs from pull request most recent head 079d0ca. Consider uploading reports for the commit 079d0ca to get more accurate results

@@             Coverage Diff              @@
##               main    #6003      +/-   ##
============================================
- Coverage     84.66%   84.64%   -0.02%     
- Complexity     3836     3846      +10     
============================================
  Files           549      549              
  Lines         13065    13092      +27     
  Branches       2305     2315      +10     
============================================
+ Hits          11061    11082      +21     
- Misses          868      869       +1     
- Partials       1136     1141       +5
Impacted Files Coverage Δ
...ub/detekt/psi/internal/FullQualifiedNameGuesser.kt 87.50% <ø> (ø)
...lab/arturbosch/detekt/rules/style/ClassOrdering.kt 82.27% <85.71%> (-2.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atulgpt atulgpt mentioned this pull request Apr 16, 2023
Closed
@atulgpt
Copy link
Contributor Author

atulgpt commented Apr 25, 2023

@BraisGabin I gues failing CI is due to intermittent failure. Right?

BraisGabin
BraisGabin approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BraisGabin BraisGabin added this to the 1.23.0 milestone Apr 27, 2023
@cortinico cortinico merged commit df82521 into detekt:main Apr 29, 2023
@atulgpt atulgpt deleted the fixes/3144 branch April 29, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
rules
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

ClassOrdering identifies minimum set of reorders
3 participants
@atulgpt @BraisGabin @cortinico