Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use detekt-versions.properties instead of versions.properties #6006

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Apr 16, 2023

Maybe fixes #5968

I am new to Gradle plugins and Gradle-related code. So this may be some issues or partial implementation

@github-actions
Copy link

github-actions bot commented Apr 16, 2023

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against fceb53c

@atulgpt
Copy link
Contributor Author

atulgpt commented Apr 16, 2023

Oops, all checks failed. It is harder than I thought 😅

@cortinico
Copy link
Member

nit: detekt-versions.properties is probably better

@atulgpt
Copy link
Contributor Author

atulgpt commented Apr 17, 2023

nit: detekt-versions.properties is probably better

I thought in the folder detekt we would keep all types of *.properties or other autogenerated files. That's why I went for folder.

BTW do you know how to fix the CI?

@cortinico
Copy link
Member

BTW do you know how to fix the CI?

Not sure but I'd give the file rename a try

@atulgpt
Copy link
Contributor Author

atulgpt commented Apr 17, 2023

Not sure but I'd give the file rename a try

File rename to detekt-versions.properties?

@atulgpt atulgpt changed the title Use detekt/versions.properties instead of versions.properties Use detekt-versions.properties instead of versions.properties Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #6006 (fceb53c) into main (b4172a6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #6006   +/-   ##
=========================================
  Coverage     84.66%   84.66%           
  Complexity     3840     3840           
=========================================
  Files           549      549           
  Lines         13071    13071           
  Branches       2305     2305           
=========================================
  Hits          11066    11066           
  Misses          868      868           
  Partials       1137     1137           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@atulgpt
Copy link
Contributor Author

atulgpt commented Apr 18, 2023

BTW do you know how to fix the CI?

Not sure but I'd give the file rename a try

Yup it worked

@cortinico cortinico added this to the 1.23.0 milestone Apr 18, 2023
@BraisGabin BraisGabin merged commit 6d58918 into detekt:main Apr 19, 2023
@atulgpt atulgpt deleted the fixes/5968 branch April 19, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version.properties in jar root may cause issues with other plugins
3 participants