Update intro.mdx to use setFrom() on detekt config#6010
Merged
Conversation
Setting the value of files() directly on config is deprecated.
3flex
requested changes
Apr 18, 2023
3flex
left a comment
3flex
left a comment
Member
There was a problem hiding this comment.
Thanks for this - please update to working syntax and we can merge.
| detekt { | ||
| toolVersion = "[detekt_version]" | ||
| config = files("config/detekt/detekt.yml") | ||
| config = setFrom(files("config/detekt/detekt.yml")) |
Member
There was a problem hiding this comment.
Suggested change
| config = setFrom(files("config/detekt/detekt.yml")) | |
| config.setFrom(file("config/detekt/detekt.yml")) |
3flex
approved these changes
Apr 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #6010 +/- ##
=========================================
Coverage 84.66% 84.66%
Complexity 3840 3840
=========================================
Files 549 549
Lines 13071 13071
Branches 2305 2305
=========================================
Hits 11066 11066
Misses 868 868
Partials 1137 1137 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the value of files() directly on config is deprecated.