Skip to content

Compile compiler plugin against kotlin-compiler-embeddable - #6012

Merged
3flex merged 1 commit into
detekt:mainfrom
3flex:6007-fix
Apr 18, 2023
Merged

3flex merged 1 commit into
detekt:mainfrom
3flex:6007-fix

Conversation

@3flex

@3flex 3flex commented Apr 18, 2023

Copy link
Copy Markdown
Member

Partially reverts #5765

Fixes #6007

@github-actions

Copy link
Copy Markdown
Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against aa0f01c

@codecov

codecov Bot commented Apr 18, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #6012 (aa0f01c) into main (bd44c2d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #6012   +/-   ##
=========================================
  Coverage     84.66%   84.66%           
  Complexity     3840     3840           
=========================================
  Files           549      549           
  Lines         13071    13071           
  Branches       2305     2305           
=========================================
  Hits          11066    11066           
  Misses          868      868           
  Partials       1137     1137           
Impacted Files Coverage Δ
.../detekt/compiler/plugin/DetektAnalysisExtension.kt 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@3flex
3flex merged commit 04defcb into detekt:main Apr 18, 2023
@cortinico

Copy link
Copy Markdown
Member

@3flex thanks for the fix. Can you clarify why this was happening?

@3flex
3flex deleted the 6007-fix branch April 19, 2023 03:20
@3flex

3flex commented Apr 19, 2023

Copy link
Copy Markdown
Member Author

I believe compiling against the standard compiler plugin meant the signature of analysisCompleted in DetektAnalysisExtension was incorrect, so it wasn't being called by the compiler when running under Gradle (since KGP under Gradle uses the embeddable compiler).

This branch was successfully deployed

1 active deployment
Preview — aa0f01c8 Deployed Apr 18, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

detekt-compiler-plugin:1.23.0-RC1 not working for my project

3 participants