Reduce eager POM task creation #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While reading a Gradle issue @3flex opened, I stumbled upon https://github.com/detekt/detekt/pull/5996/files#diff-8a7fc388e89cfbc32780b6887c089aeb9fecbb1e231a51c553e2c87388af7148R60, which as far as I remember is eager. Also swapped `if` with `withType` since there's no need to add the callback on newer versions of Gradle, JVM running Gradle is not going to change, not even when Toolchains are used.
TWiStErRob
added
build
housekeeping
Codecov Report
@@ Coverage Diff @@
## main #6041 +/- ##
=========================================
Coverage 84.84% 84.84%
Complexity 3944 3944
=========================================
Files 561 561
Lines 13251 13251
Branches 2313 2313
=========================================
Hits 11243 11243
Misses 868 868
Partials 1140 1140 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I can't believe I forgot |
3flex
approved these changes
Apr 25, 2023
|
No worries 🫣, I'm setting a milestone as 23 is just around the corner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading a Gradle issue @3flex opened, I stumbled upon https://github.com/detekt/detekt/pull/5996/files#diff-8a7fc388e89cfbc32780b6887c089aeb9fecbb1e231a51c553e2c87388af7148R60, which as far as I remember is eager. Also swapped
ifwithwithTypesince there's no need to add the callback on newer versions of Java, JVM running Gradle is not going to change, not even when Toolchains are used.