Fix incomplete requireRootInDeclaration check in InvalidPackageDeclaration - #6045
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6045 +/- ##
============================================
- Coverage 84.84% 84.83% -0.01%
- Complexity 3944 3946 +2
============================================
Files 561 561
Lines 13251 13256 +5
Branches 2313 2314 +1
============================================
+ Hits 11243 11246 +3
- Misses 868 869 +1
- Partials 1140 1141 +1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code used
String.startsWith()to check if the package declaration is the root package or a subpackage of it. This check erroneously allows "sibling packages" that start with the root package name, e.g. "com.example_extra" when the root package name is "com.example".This PR adds a test for that case and fixes the check to work as intended.