Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce LoopWithTooManyJumpStatements finding scope #6110

Merged
merged 2 commits into from May 20, 2023

Conversation

TWiStErRob
Copy link
Member

Similar to other PRs where we reduced the scope.

Real life use case where it hides other warnings, and just plain huge yellow blob:
image

Contains a commit from #6107 + splits up the test cases before changing code.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #6110 (1d532a7) into main (f99ac58) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #6110      +/-   ##
============================================
- Coverage     84.89%   84.88%   -0.02%     
  Complexity     4022     4022              
============================================
  Files           569      569              
  Lines         13449    13457       +8     
  Branches       2371     2375       +4     
============================================
+ Hits          11418    11423       +5     
- Misses          871      872       +1     
- Partials       1160     1162       +2     
Impacted Files Coverage Δ
...etekt/rules/style/LoopWithTooManyJumpStatements.kt 87.09% <66.66%> (-8.56%) ⬇️

@cortinico cortinico added this to the 1.23.0 milestone May 20, 2023
@cortinico
Copy link
Member

@TWiStErRob can you rebase?

@cortinico cortinico enabled auto-merge (squash) May 20, 2023 14:27
@cortinico cortinico merged commit 67d2c72 into detekt:main May 20, 2023
22 of 23 checks passed
@TWiStErRob TWiStErRob deleted the loop-keyword branch May 20, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants