Skip to content

SleepInsteadOfDelay - Find the parent for suspend check - #6191

Merged
BraisGabin merged 1 commit into
detekt:mainfrom
atulgpt:fixes/6176/traverse-parent
Aug 13, 2023
Merged

BraisGabin merged 1 commit into
detekt:mainfrom
atulgpt:fixes/6176/traverse-parent

Conversation

@atulgpt

@atulgpt atulgpt commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Fixes #6176

Traverse in the parent for finding the suitable property or argument for suspension check

@detekt-ci detekt-ci added the rules label Jun 7, 2023
@atulgpt

atulgpt commented Jun 7, 2023

Copy link
Copy Markdown
Contributor Author
failing_tc

Failing TCs(as per the main code) which got fixed

@atulgpt
atulgpt force-pushed the fixes/6176/traverse-parent branch from 2a29847 to 273b422 Compare August 4, 2023 10:03
@atulgpt

atulgpt commented Aug 4, 2023 •

Copy link
Copy Markdown
Contributor Author

Hi, @cortinico @BraisGabin PTAL

@codecov

codecov Bot commented Aug 4, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6191 (273b422) into main (67cd931) will decrease coverage by 0.04%.
The diff coverage is 60.52%.

@@             Coverage Diff              @@
##               main    #6191      +/-   ##
============================================
- Coverage     85.16%   85.13%   -0.04%     
- Complexity     4010     4013       +3     
============================================
  Files           570      570              
  Lines         13401    13418      +17     
  Branches       2363     2369       +6     
============================================
+ Hits          11413    11423      +10     
- Misses          834      835       +1     
- Partials       1154     1160       +6     
Files Changed Coverage Δ
...sch/detekt/rules/coroutines/SleepInsteadOfDelay.kt 69.69% <60.52%> (-3.78%) ⬇️

@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label Aug 4, 2023
@cortinico cortinico changed the title Find the parent for suspend check SleepInsteadOfDelay - Find the parent for suspend check Aug 4, 2023
@BraisGabin BraisGabin added this to the 2.0.0 milestone Aug 13, 2023
@BraisGabin
BraisGabin merged commit 484f1eb into detekt:main Aug 13, 2023
@atulgpt
atulgpt deleted the fixes/6176/traverse-parent branch August 13, 2023 11:48
cortinico pushed a commit that referenced this pull request Oct 30, 2023
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024

This branch was successfully deployed

1 active deployment
Preview — 273b422a Deployed Aug 4, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pick request Marker for PRs that should be ported to the 1.0 release branch rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive in SleepInsteadOfDelay rule in 1.23.0

4 participants