Skip to content

Fix inputstream leaking file descriptor in Gradle#6519

Merged
BraisGabin merged 1 commit into
detekt:mainfrom
pablobaxter:main
Oct 1, 2023
Merged

Fix inputstream leaking file descriptor in Gradle#6519
BraisGabin merged 1 commit into
detekt:mainfrom
pablobaxter:main

Conversation

@pablobaxter

Copy link
Copy Markdown
Contributor

Fixes #6518

@detekt-ci

Copy link
Copy Markdown
Collaborator
Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against 77ad668

@codecov

codecov Bot commented Sep 30, 2023

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7a9d960) 85.18% compared to head (77ad668) 85.18%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6519   +/-   ##
=========================================
  Coverage     85.18%   85.18%           
  Complexity     4037     4037           
=========================================
  Files           564      564           
  Lines         13273    13273           
  Branches       2387     2387           
=========================================
  Hits          11306    11306           
  Misses          773      773           
  Partials       1194     1194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schalkms schalkms left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for detekting and fixing this issue! 🙂

@schalkms schalkms added this to the 1.23.2 milestone Sep 30, 2023
@BraisGabin BraisGabin added the pick request Marker for PRs that should be ported to the 1.0 release branch label Oct 1, 2023
@BraisGabin BraisGabin merged commit 3b23142 into detekt:main Oct 1, 2023
@Rodrigolmti

Copy link
Copy Markdown

Hello, do we have any estimation of when this fix will be released? Seems that it is impacting some projects out there.

@cortinico cortinico modified the milestones: 1.23.2, 2.0.0 Oct 22, 2023
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gradle-plugin pick request Marker for PRs that should be ported to the 1.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File Descriptor Leak in DetektExtension.kt

6 participants