Fix issues related to kotlin-stdlib's Gradle module metadata in Kotlin 1.9.20 #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test fixtures aren't published and there's no need to specify this dependency for internal consumers.
3flex
added
the
pick request
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6590 +/- ##
=========================================
Coverage 85.18% 85.18%
Complexity 4061 4061
=========================================
Files 565 565
Lines 13321 13321
Branches 2401 2401
=========================================
Hits 11347 11347
Misses 773 773
Partials 1201 1201 ☔ View full report in Codecov by Sentry. |
kotlin-stdlib is now published with Gradle module metadata which has caused a new issue because we use consistent dependency resolution (see useCompileClasspathVersions). Updating the version of the dependency in the compile classpath fixes it. KT-49803 is already open to request removing annotations as a transitive dependency. Until that's fixed this setup will allow builds to operate correctly.
TWiStErRob
approved these changes
Nov 1, 2023
cortinico
pushed a commit
that referenced
this pull request
Nov 25, 2023
…n 1.9.20 (#6590) * Remove redundant dependency Test fixtures aren't published and there's no need to specify this dependency for internal consumers. * Use latest annotations version in compile classpath kotlin-stdlib is now published with Gradle module metadata which has caused a new issue because we use consistent dependency resolution (see useCompileClasspathVersions). Updating the version of the dependency in the compile classpath fixes it. KT-49803 is already open to request removing annotations as a transitive dependency. Until that's fixed this setup will allow builds to operate correctly.
mgroth0
pushed a commit
to mgroth0/detekt
that referenced
this pull request
Feb 11, 2024
…n 1.9.20 (detekt#6590) * Remove redundant dependency Test fixtures aren't published and there's no need to specify this dependency for internal consumers. * Use latest annotations version in compile classpath kotlin-stdlib is now published with Gradle module metadata which has caused a new issue because we use consistent dependency resolution (see useCompileClasspathVersions). Updating the version of the dependency in the compile classpath fixes it. KT-49803 is already open to request removing annotations as a transitive dependency. Until that's fixed this setup will allow builds to operate correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle module metadata is published alongside kotlin-stdlib from 1.9.20 which caused a couple of dependency issues due to our use of
useCompileClasspathVersionsfor consistent dependency resolution.This fixes them and will unblock 1.9.20 update.