Skip to content

UnusedPrivateClass: don't report if private classes are used for type conversion - #6995

Merged
BraisGabin merged 1 commit into
detekt:mainfrom
t-kameyama:issue_6982
Feb 27, 2024
Merged

UnusedPrivateClass: don't report if private classes are used for type conversion#6995
BraisGabin merged 1 commit into
detekt:mainfrom
t-kameyama:issue_6982

Conversation

@t-kameyama

Copy link
Copy Markdown
Contributor

Fixes #6982

@codecov

codecov Bot commented Feb 27, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.78%. Comparing base (a263ecb) to head (5762717).

Files Patch % Lines
...rturbosch/detekt/rules/style/UnusedPrivateClass.kt 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6995      +/-   ##
============================================
- Coverage     83.79%   83.78%   -0.02%     
  Complexity     3932     3932              
============================================
  Files           579      579              
  Lines         12100    12104       +4     
  Branches       2506     2508       +2     
============================================
+ Hits          10139    10141       +2     
  Misses          710      710              
- Partials       1251     1253       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BraisGabin

Copy link
Copy Markdown
Member

Thanks!

@BraisGabin
BraisGabin merged commit 70c7586 into detekt:main Feb 27, 2024
@detekt-ci

Copy link
Copy Markdown
Collaborator
Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against 5762717

@BraisGabin BraisGabin added this to the 2.0.0 milestone Feb 27, 2024
@BraisGabin BraisGabin added the pick request Marker for PRs that should be ported to the 1.0 release branch label Feb 27, 2024
@t-kameyama
t-kameyama deleted the issue_6982 branch February 27, 2024 08:37
cortinico pushed a commit that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pick request Marker for PRs that should be ported to the 1.0 release branch rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnusedPrivateClass Rule does not detect casts as usage

3 participants