Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

`.../submit` command never returns if the event is `cancel` during bubbling up #107

Closed
detro opened this Issue · 1 comment

1 participant

@detro
Owner

Jim Evans said:

Also found a major bug in the #ghostdriver "submit" implementation. Have no idea how to fix it. If the page issues a 'cancel' in the onsubmit event handler, the ghostdriver submit method will never return. Mainly because our onLoadFinished callback will never get called (because no load actually happens).

@detro
Owner

I think I have a clean solution to this, that does nice code reuse ;)

@detro detro referenced this issue from a commit
@detro Handle case when "submit" doesn't return.
This happens when the "onsubmit" event gets aborted within the page.
In the current implementation, we would wait indefinitely.
This fix makes sure we "timeout" and report the error.

Closes Issue #107.
279b6c5
@detro detro closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.