Upgrade to selenium 2.44.0 #399

Merged
merged 2 commits into from Oct 26, 2014

Projects

None yet
@asolntsev
Contributor
@detro
Owner
detro commented Oct 26, 2014

Awesome. Merging. Thanks :)

@detro detro merged commit d57f72c into detro:master Oct 26, 2014
@bpmacedo

Hi there!

Do u know when it'll be released?

Thx,
Bruno Macedo.

@zch
zch commented Oct 29, 2014

This closes issue #397, any idea when we can see a release with this fix?

@robertoschwald

Need that too, badly! Please release.

@cch1
cch1 commented Oct 30, 2014

Me Too!

@asolntsev asolntsev deleted the asolntsev:upgrade-to-selenium-2-44 branch Oct 30, 2014
@inka
inka commented Nov 4, 2014

+1 for releasing that stuff please!

@andresriancho

Will you guys release it as part of the npm package ? When? This is a critical fix!

@mikx
mikx commented Nov 7, 2014

Please release this fix!

@iceone23
iceone23 commented Nov 9, 2014

Great! I hope fixed release will be soon.

@adlenafane

👍

@kpiwko
kpiwko commented Nov 10, 2014

Same here, waiting for new release to integrate it with Arquillian Drone.

@drdozer
drdozer commented Nov 13, 2014

This is a showstopper for me. A release with this in would be good to have ;D

@ReactiveRaven ReactiveRaven referenced this pull request in angular/protractor Nov 15, 2014
Closed

1.4.0 does not seem to work with PhantomJS #1512

@acdcjunior

For those of you who don't mind a temporary hack (like me), just add this class to your (Java) project:

package org.openqa.selenium.browserlaunchers;
import org.openqa.selenium.Capabilities;
import org.openqa.selenium.Proxy;
public class Proxies {
    public static Proxy extractProxy(Capabilities capabilities) {
        return Proxy.extractFrom(capabilities);
    }
}

And it should get back working (or at least it did for me).
My setup is:

  • org.seleniumhq.selenium:selenium-remote-driver:2.44.0 and org.seleniumhq.selenium:selenium-server:2.44.0 (declared above the dependencies below, because ghostdriver is overriding them with 2.39.0)
  • org.seleniumhq.selenium:selenium-java:2.44.0
  • com.github.detro.ghostdriver:phantomjsdriver:1.1.0
  • phantomjs.exe version 1.9.7 under windows 8.

(If my ghostdriver/phantomjs.exe pairing is wrong, please let me know -- I really find this versioning confusing, that's why I'm not using 1.2.0 yet: I can't figure out, within my attention span, if it is released and should be used or not.)

@iceone23

Thank you, Antonio! That work for me :)
But then I get another error:

Exception in thread "main" java.lang.NoClassDefFoundError: com/google/common/base/Function
    at org.leospammer.phantomjs.ExampleScenario.main(ExampleScenario.java:23)
Caused by: java.lang.ClassNotFoundException: com.google.common.base.Function
    at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
    at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
    ... 1 more

@acdcjunior

@iceone23 I don't mean to bring this thread into off-topic madness, but just to comment on your last error, it seems like a Guava/GoogleCollections dependency is having its version number overridden. Keep in mind selenium-firefox-driver:2.44.0 requires selenium-remote-driver:2.44.0 that in turn requires guava:18.0, so it may be shadowing some older Guava/GoogleCollections version your project depended on.

@wakaleo
wakaleo commented Nov 19, 2014

+1 We need this for Serenity as well.

@TikhomirovSergey

+1. I am waiting for this fix.

@mgijsberti

+1 for this issue to be fixed.

@xdamman
xdamman commented Nov 20, 2014

+1

@edwolb
edwolb commented Nov 27, 2014

+1

@typekpb
typekpb commented Nov 28, 2014

+1

@chino23
chino23 commented Dec 2, 2014

+1

@amesbah amesbah added a commit to crawljax/crawljax that referenced this pull request Dec 3, 2014
@amesbah amesbah ghostdriver for phantomjs is broken with selenium 2.44.0, see detro/g…
…hostdriver#399 for now we are going back to 2.44.0
d378ff0
@amesbah
amesbah commented Dec 3, 2014

Are there any plans to release this important fix in Maven any time soon?

@asolntsev
Contributor

Hi all!
I have published patched PhantomJS in our Maven repo. Feel free to use it until the official PhantomJS is released:

<dependency>
    <groupId>com.codeborne</groupId>
    <artifactId>phantomjsdriver</artifactId>
    <version>1.2.1</version>
</dependency>

This version is PhantomJS 1.2.0 patched for working with Selenium 2.44.0

@amesbah
amesbah commented Dec 4, 2014

Fantastic! Thanks.

@laurelnaiad laurelnaiad added a commit to marklogic/marklogic-samplestack that referenced this pull request Dec 10, 2014
@laurelnaiad laurelnaiad e2e: force protractor to use selenium 2.43.1
This is the last version of selenium compatible with PhantomJS until
PhantomJS/Ghostdriver is updated. On postinstall of the application,
modify protractor configuration to use 2.43.1.

Watch for detro/ghostdriver#399 to be included
in a released version and then undo this.
d94f5e2
@christian-bromann christian-bromann referenced this pull request in webdriverio/webdriverio Dec 28, 2014
Closed

PhantomJS with webdriverio #342

@jvanderwee

+1

@nottoseethesun

+1 - what andresriancho said.

@KabanaSoft

Guys,

I'm trying to get a fix in place until an official release is made and am a little confused as to how to tell PhantomJs to use specific ghostdriver that contains the fix. I have grabbed the latest ghostdriver source from master and also downloaded the 1.2.1 fix mentioned by @asolntsev from here: http://mvnrepository.com/artifact/com.codeborne/phantomjsdriver/1.2.1.

I am using C# WebDriver bindings, running a selenium server 2.44.0 and PhantomJs 1.9.8. From my understanding PhantomJs has an old ghostdriver embedded into it that doesn't contain a fix for this issue, but you can override that using the phantomjs.ghostdriver.path option (i read this here: https://github.com/detro/ghostdriver/blob/master/README.md). I have tried using the following code to specify the custom ghostdriver path:

capabilities.SetCapability("phantomjs.ghostdriver.path", @"C:\ghostdriver-master\src\main.js");

I have tried many different options as well as pointing to the phantomjsdriver-1.2.1.jar file that i downloaded and still can't get it to work.

Do you have any suggestions on how i can get PhantomJs to use the updated ghostdriver that has this fix implemented? (i think im a little confused on exactly how to use this setting)

Any help would be greatly appreciated, thanks!

@luksch
luksch commented Jan 29, 2015

+1

Is there a problem with releasing this? I am still waiting desperately.

BTW: Thanks you all for the work you put into this. My work could not be with selenium, phantomjs and the awesome ghostdriver.

@Robinfr
Robinfr commented Feb 27, 2015

+1 for releasing this.

@kpiwko
kpiwko commented Mar 2, 2015

Just as future note, Arquillian Drone and Graphene is migrating to com.codeborne fork. Selenium 2.45.0 was released recently and this issue takes 6 month to be released. Thanks @asolntsev for making that possible!

@rck109d
rck109d commented Mar 11, 2015

+1

@lambrojos

+1

@lucaspouzac

+1 :)

@djeikyb
djeikyb commented Apr 16, 2015

I'm not sure if I can trust @asolntsev. @kpiwko vouches for him, claiming the arquillian stuff is switching to his fork. But I don't know of @kpiwko either. You can verify this claim following transitive dependencies:

  1. https://github.com/arquillian/arquillian-graphene/blob/87dd6253329ed55801ebcb955431b89aba9645bf/pom.xml
  2. https://github.com/arquillian/arquillian-extension-drone/blob/8b54eb8915d217e1028fc82631fd966903c27fa2/drone-bom/pom.xml
  3. https://github.com/qa/arquillian-phantom-driver/blob/c86f2749f8a99e1ed4233049c211a691d71d38ef/pom.xml

@kpiwko is apparently a RedHat employee, and you can see his contributions on this site. Since his claim checks out, it seems reasonable to transitively trust @asolntsev.

Just thought I'd mention this in case anyone else was a little hesitant to start using the @asolntsev fork.

@asolntsev
Contributor

Hi Djeikyb!

What i like about open-source development is that you don't need to
trust me. The only think in the World you can trust is the code. You
can just compare original phantomjs code and my fork and verify that
there is no more difference but the few required lines of code.

Sincerely yours,
@asolntsev

2015-04-16 16:06 GMT+08:00, djeikyb notifications@github.com:

I'm not sure if I can trust @asolntsev. @kpiwko vouches for him, claiming
the arquillian stuff is switching to his fork. But I don't know of @kpiwko
either. You can verify this claim following transitive dependencies:

https://github.com/arquillian/arquillian-graphene/blob/87dd6253329ed55801ebcb955431b89aba9645bf/pom.xml

https://github.com/arquillian/arquillian-extension-drone/blob/8b54eb8915d217e1028fc82631fd966903c27fa2/drone-bom/pom.xml

https://github.com/qa/arquillian-phantom-driver/blob/c86f2749f8a99e1ed4233049c211a691d71d38ef/pom.xml

@kpiwko is apparently a RedHat employee, and you can see his contributions
on this site. Since his claim checks out, it seems reasonable to
transitively trust @asolntsev.

Just thought I'd mention this in case anyone else was a little hesitant to
start using the @asolntsev fork.


Reply to this email directly or view it on GitHub:
#399 (comment)

Andrei Solntsev

@luksch
luksch commented Apr 16, 2015

@asolntsev do you have any knowledge about what actaully happened to this repo here? I mean why it is abandoned? Maybe there should be a message in the readme.me telling people that this repo is not maintained any more.

@erdi
Contributor
erdi commented Apr 16, 2015

This repo doesn't look abandoned, @detro has made a commit 9hrs ago. There simply are no new releases for some reason...

@luksch
luksch commented Apr 16, 2015

That is good news! interesting timing for the first commit since November :) I would be more than glad if @detro continues his wonderful work!

@asolntsev
Contributor

Yes,
some months ago @detro wrote that he is not able to support the project anymore, and asked for volunteers. I guess he found somebody.

Sent from my HTC

----- Reply message -----
From: "luksch" notifications@github.com
To: "detro/ghostdriver" ghostdriver@noreply.github.com
Cc: "Andrei Solntsev" andrei.solntsev@gmail.com
Subject: [ghostdriver] Upgrade to selenium 2.44.0 (#399)
Date: Fri, Apr 17, 2015 02:01

@asolntsev do you have any knowledge about what actaully happened to this repo here? I mean why it is abandoned? Maybe there should be a message in the readme.me telling people that this repo is not maintained any more.


Reply to this email directly or view it on GitHub.

@GrayedFox

This would resolve so many headaches on my end!!! +1 to release this asap.

@jeffnyman

Just chiming in as others have done to see if a release is going to happen. If not, okay, but then let's make that abundantly clear to everyone. Incidentally, I came here via this ticket (#397). I'm using the solution provided there by @asolntsev and it's working fine.

Given that the "GhostDriver needs a proper maintainer" text is still on the readme, I'm guessing that a proper maintainer has not yet been found?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment