File upload hack #89

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@jimevans
Contributor

jimevans commented Oct 9, 2012

Resubmitted pull request after git rebase

This pull request is a gross hack so that file uploading will work with GhostDriver. I'm submitting the pull request only to get the issue on the radar. The hack is clearly marked with comments in the code. To make this work correctly, we will need a proper fix in the PhantomJS project, or we will need to manipulate an attribute of the element so that the PhantomJS uploadFile() method can uniquely find the file upload element on the page.

@ghost ghost assigned detro Oct 12, 2012

@detro

This comment has been minimized.

Show comment Hide comment
@detro

detro Oct 24, 2012

Owner

While almost drunk @jimevans and I concluded that it might be a good idea if PhantomJS offered an API that allowed to "pre-type" the Path to the file, but didn't need an element to "click on" (to open the File Selector Window Popup).

We can than just "click" on that element, that will cause the popup window to be invoked, and PhantomJS should already know how to fill that in.

We should be in business.

Owner

detro commented Oct 24, 2012

While almost drunk @jimevans and I concluded that it might be a good idea if PhantomJS offered an API that allowed to "pre-type" the Path to the file, but didn't need an element to "click on" (to open the File Selector Window Popup).

We can than just "click" on that element, that will cause the popup window to be invoked, and PhantomJS should already know how to fill that in.

We should be in business.

detro added a commit that referenced this pull request Oct 29, 2012

Handling file upload.
This is the result of the discovery work done by
@jimevans. I have:
- updated PhantomJS to provide a callback "onFilePicker"
- reworked his hack

Closes Issue #89.
@detro

This comment has been minimized.

Show comment Hide comment
@detro

detro Oct 29, 2012

Owner

Closed by b157e79

Owner

detro commented Oct 29, 2012

Closed by b157e79

@detro detro closed this Oct 29, 2012

@detro

This comment has been minimized.

Show comment Hide comment
@detro

detro Oct 29, 2012

Owner

@jimevans Can you let me know if this works for you too?
Also, if you have a test case for this, would you mind adding it to the Java tests in here :)
Pretty please? ;)

Owner

detro commented Oct 29, 2012

@jimevans Can you let me know if this works for you too?
Also, if you have a test case for this, would you mind adding it to the Java tests in here :)
Pretty please? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment