Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grants page #42

Merged
merged 11 commits into from
Feb 28, 2021
Merged

Grants page #42

merged 11 commits into from
Feb 28, 2021

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Oct 5, 2020 •
edited
Loading

Changes:

  • From grants table on an organization page, link each grant description to individual grant page
  • Basic grant page layout
  • Extend GrantTable component to support related grants (don't show yearly sums bar charts for related grants)
  • Format and clean up content (strip hmtl from grant descriptions, only show year of grant dates, consistent display of $, etc)

@jessicamcinchak jessicamcinchak marked this pull request as draft October 6, 2020 16:30
@jessicamcinchak jessicamcinchak changed the title Grants page [WIP] Grants page Oct 6, 2020
@jessicamcinchak jessicamcinchak linked an issue Dec 29, 2020 that may be closed by this pull request
Front-end launch checklist #20
Open
28 tasks
@jessicamcinchak jessicamcinchak marked this pull request as ready for review December 29, 2020 18:24
@jessicamcinchak jessicamcinchak removed a link to an issue Dec 29, 2020
Front-end launch checklist #20
Open
28 tasks
@jessicamcinchak jessicamcinchak mentioned this pull request Dec 29, 2020
Open
28 tasks
hampelm
hampelm approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@hampelm hampelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's ship it!

@hampelm hampelm merged commit 0c3ae58 into master Feb 28, 2021
@jessicamcinchak jessicamcinchak deleted the grants-page branch April 23, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hampelm hampelm hampelm approved these changes

@bnchdrff bnchdrff Awaiting requested review from bnchdrff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamcinchak @hampelm