Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Wall to compiler flags #203

Merged
merged 1 commit into from Jun 4, 2017

Conversation

@robertodr
Copy link
Contributor

commented Jun 2, 2017

Also add -Wextra, where available. The warning flags are added to CMAKE_<LANG>_FLAGS so that one gets warnings also in release builds. 'Cause life is too short to deactivate or ignore compiler warnings!

@miroi

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2017

This is good initiative. Let us make 'rule' that by default we switch on all compilers warnings.

@bast bast merged commit c4cbe7c into dev-cafe:master Jun 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bast

This comment has been minimized.

Copy link
Member

commented Jun 4, 2017

Thank you! Very good path forward.

@robertodr robertodr deleted the robertodr:warning_flags branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.