Skip certain recipes when they are known not to work

dev-cafe · Sep 21, 2018 · 5321756 · 5321756
1 parent 2417e94
commit 5321756
Show file tree

Hide file tree

Showing 38 changed files with 56 additions and 39 deletions.
diff --git a/chapter-01/recipe-01/fortran-example/menu.yml b/chapter-01/recipe-01/fortran-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-01/recipe-02/fortran-example/menu.yml b/chapter-01/recipe-02/fortran-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-01/recipe-03/fortran-example/menu.yml b/chapter-01/recipe-03/fortran-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-01/recipe-09/fortran-example/menu.yml b/chapter-01/recipe-09/fortran-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-02/recipe-03/fortran-example/menu.yml b/chapter-02/recipe-03/fortran-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-02/recipe-06/cxx-example/menu.yml b/chapter-02/recipe-06/cxx-example/menu.yml
@@ -5,14 +5,14 @@ circle-intel:
 circle-pgi:
   definitions:
     - Eigen3_DIR: '/opt/eigen/share/eigen3/cmake'
-      
+
 travis-linux:
   definitions:
     - Eigen3_DIR: '$HOME/Deps/eigen/share/eigen3/cmake'
 
 # OpenMP does not work with clang
 travis-osx:
-  failing_generators:
+  skip_generators:
     - 'Unix Makefiles'
     - 'Ninja'
 

diff --git a/chapter-03/recipe-04/cxx-example/menu.yml b/chapter-03/recipe-04/cxx-example/menu.yml
@@ -1,3 +1,4 @@
+# No suitable native BLAS/LAPACK with MSVC
 appveyor-vs:
   failing_generators:
     - 'Visual Studio 15 2017 Win64'

diff --git a/chapter-03/recipe-05/cxx-example-3.5/menu.yml b/chapter-03/recipe-05/cxx-example-3.5/menu.yml
@@ -1,5 +1,5 @@
 # OpenMP does not work with clang
 travis-osx:
-  failing_generators:
+  skip_generators:
     - 'Unix Makefiles'
     - 'Ninja'
diff --git a/chapter-03/recipe-05/cxx-example/menu.yml b/chapter-03/recipe-05/cxx-example/menu.yml
@@ -1,5 +1,5 @@
 # OpenMP does not work with clang
 travis-osx:
-  failing_generators:
+  skip_generators:
     - 'Unix Makefiles'
     - 'Ninja'
diff --git a/chapter-03/recipe-05/fortran-example-3.5/menu.yml b/chapter-03/recipe-05/fortran-example-3.5/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-03/recipe-05/fortran-example/menu.yml b/chapter-03/recipe-05/fortran-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-03/recipe-06/c-example-3.5/menu.yml b/chapter-03/recipe-06/c-example-3.5/menu.yml
@@ -4,7 +4,8 @@ appveyor-vs:
     - MSMPI_INC: 'C:\Program Files (x86)\Microsoft SDKs\MPI\Include\'
     - MSMPI_LIB32: 'C:\Program Files (x86)\Microsoft SDKs\MPI\Lib\x86\'
     - MSMPI_LIB64: 'C:\Program Files (x86)\Microsoft SDKs\MPI\Lib\x64\'
-
+
+# No suitable MPI with MSYS
 appveyor-msys:
   failing_generators:
     - 'MSYS Makefiles'

diff --git a/chapter-03/recipe-06/c-example/menu.yml b/chapter-03/recipe-06/c-example/menu.yml
@@ -5,6 +5,7 @@ appveyor-vs:
     - MSMPI_LIB32: 'C:\Program Files (x86)\Microsoft SDKs\MPI\Lib\x86\'
     - MSMPI_LIB64: 'C:\Program Files (x86)\Microsoft SDKs\MPI\Lib\x64\'
 
+# No suitable MPI with MSYS
 appveyor-msys:
   failing_generators:
     - 'MSYS Makefiles'

diff --git a/chapter-03/recipe-06/cxx-example/menu.yml b/chapter-03/recipe-06/cxx-example/menu.yml
@@ -5,6 +5,7 @@ appveyor-vs:
     - MSMPI_LIB32: 'C:\Program Files (x86)\Microsoft SDKs\MPI\Lib\x86\'
     - MSMPI_LIB64: 'C:\Program Files (x86)\Microsoft SDKs\MPI\Lib\x64\'
 
+# No suitable MPI with MSYS
 appveyor-msys:
   failing_generators:
     - 'MSYS Makefiles'

diff --git a/chapter-03/recipe-07/cxx-example-3.5/menu.yml b/chapter-03/recipe-07/cxx-example-3.5/menu.yml
@@ -16,7 +16,7 @@ travis-linux:
 
 # OpenMP does not work with clang
 travis-osx:
-  failing_generators:
+  skip_generators:
     - 'Unix Makefiles'
     - 'Ninja'
 

diff --git a/chapter-03/recipe-07/cxx-example/menu.yml b/chapter-03/recipe-07/cxx-example/menu.yml
@@ -16,7 +16,7 @@ travis-linux:
 
 # OpenMP does not work with clang
 travis-osx:
-  failing_generators:
+  skip_generators:
     - 'Unix Makefiles'
     - 'Ninja'
 

diff --git a/chapter-03/recipe-09/c-example-3.5/menu.yml b/chapter-03/recipe-09/c-example-3.5/menu.yml
@@ -1,3 +1,4 @@
+# No pkg-config with Visual Studio generator
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
diff --git a/chapter-03/recipe-09/c-example/menu.yml b/chapter-03/recipe-09/c-example/menu.yml
@@ -1,5 +1,6 @@
+# No pkg-config with Visual Studio generator
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 # Fails to generate imported target for ZeroMQ

diff --git a/chapter-05/recipe-03/cxx-example/menu.yml b/chapter-05/recipe-03/cxx-example/menu.yml
@@ -1,6 +1,6 @@
 appveyor-vs:
-  failing_generators:
-    - 'Visual Studio 15 2017 Win64' 
+  skip_generators:
+    - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:
   failing_generators:

diff --git a/chapter-05/recipe-04/cxx-example/menu.yml b/chapter-05/recipe-04/cxx-example/menu.yml
@@ -1,6 +1,6 @@
 appveyor-vs:
-  failing_generators:
-    - 'Visual Studio 15 2017 Win64' 
+  skip_generators:
+    - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:
   failing_generators:

diff --git a/chapter-05/recipe-05/fortran-example/menu.yml b/chapter-05/recipe-05/fortran-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-05/recipe-08/c-example-3.5/menu.yml b/chapter-05/recipe-08/c-example-3.5/menu.yml
@@ -1,7 +1,9 @@
+# No pkg-config with Visual Studio generator
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
+# UUID can't be found on MSYS
 appveyor-msys:
   failing_generators:
     - 'MSYS Makefiles'

diff --git a/chapter-05/recipe-08/c-example/menu.yml b/chapter-05/recipe-08/c-example/menu.yml
@@ -1,7 +1,9 @@
+# No pkg-config with Visual Studio generator
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
+# UUID can't be found on MSYS
 appveyor-msys:
   failing_generators:
     - 'MSYS Makefiles'

diff --git a/chapter-05/recipe-09/cxx-example/menu.yml b/chapter-05/recipe-09/cxx-example/menu.yml
@@ -5,7 +5,8 @@ appveyor-vs:
     - MSMPI_LIB32: 'C:\Program Files (x86)\Microsoft SDKs\MPI\Lib\x86\'
     - MSMPI_LIB64: 'C:\Program Files (x86)\Microsoft SDKs\MPI\Lib\x64\'
 
+# No suitable MPI with MSYS
 appveyor-msys:
-  failing_generators:
+  skip_generators:
     - 'MSYS Makefiles'
     - 'Ninja'
diff --git a/chapter-06/recipe-01/fortran-c-example/menu.yml b/chapter-06/recipe-01/fortran-c-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-06/recipe-02/fortran-c-example/menu.yml b/chapter-06/recipe-02/fortran-c-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-06/recipe-04/fortran-example/menu.yml b/chapter-06/recipe-04/fortran-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-07/recipe-09/fortran-example/menu.yml b/chapter-07/recipe-09/fortran-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:
@@ -12,3 +12,7 @@ targets:
 travis-linux:
   failing_generators:
     - 'Ninja'
+
+travis-osx:
+  failing_generators:
+    - 'Ninja'
diff --git a/chapter-09/recipe-01/fortran-c-example/menu.yml b/chapter-09/recipe-01/fortran-c-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-09/recipe-01/fortran-cxx-example/menu.yml b/chapter-09/recipe-01/fortran-cxx-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-09/recipe-01/fortran-uuid-example-3.5/menu.yml b/chapter-09/recipe-01/fortran-uuid-example-3.5/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-09/recipe-01/fortran-uuid-example/menu.yml b/chapter-09/recipe-01/fortran-uuid-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-09/recipe-02/cxx-example/menu.yml b/chapter-09/recipe-02/cxx-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-09/recipe-06/fortran-example/menu.yml b/chapter-09/recipe-06/fortran-example/menu.yml
@@ -2,7 +2,7 @@ targets:
   - test
 
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-11/recipe-03/fortran-example/menu.yml b/chapter-11/recipe-03/fortran-example/menu.yml
@@ -1,5 +1,5 @@
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:

diff --git a/chapter-13/recipe-02/fortran-example/menu.yml b/chapter-13/recipe-02/fortran-example/menu.yml
@@ -3,15 +3,15 @@ targets:
   - install
 
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 appveyor-msys:
   failing_generators:
     - 'Ninja'
 
 travis-osx:
-  failing_generators:
+  skip_generators:
     - 'Unix Makefiles'
     - 'Ninja'
 

diff --git a/chapter-14/recipe-03/fortran-example/menu.yml b/chapter-14/recipe-03/fortran-example/menu.yml
@@ -1,8 +1,9 @@
 targets:
   - test
 
+# No ASan on Windows
 appveyor-vs:
-  failing_generators:
+  skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
 # No ASan on Windows

diff --git a/chapter-14/recipe-04/cxx-example/menu.yml b/chapter-14/recipe-04/cxx-example/menu.yml
@@ -6,13 +6,14 @@ appveyor-vs:
   skip_generators:
     - 'Visual Studio 15 2017 Win64'
 
+# No TSan on Windows
 appveyor-msys:
   skip_generators:
     - 'MSYS Makefiles'
     - 'Ninja'
 
 # OpenMP does not work with clang
 travis-osx:
-  failing_generators:
+  skip_generators:
     - 'Unix Makefiles'
     - 'Ninja'