login.defs.erb contains a non-ASCII character which causes a knife cookbook upload failure #122

Closed
gregorkistler opened this Issue Jul 10, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@gregorkistler

$ knife cookbook upload os-hardening
ERROR: ArgumentError: invalid byte sequence in US-ASCII

$ grep --color='auto' -P -n "[\x80-\xFF]" cookbooks//templates//*
cookbooks/os-hardening/templates/default/login.defs.erb:95:# If set to yes, userdel will remove the user**??**s group if it contains no more members, and useradd will create by default a group with the name of the user.

Original content:
# If set to yes, userdel will remove the user´s group if it contains no more members, and useradd will create by default a group with the name of the user.

Could you please use a ' instead of a ´ ?

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Jul 11, 2016

Member

Hi @gregorkistler,
thanks for finding this. i will fix this in the next couple weeks. Because i am working on chef-postgres-hardening and i will finish this first

Member

atomic111 commented Jul 11, 2016

Hi @gregorkistler,
thanks for finding this. i will fix this in the next couple weeks. Because i am working on chef-postgres-hardening and i will finish this first

atomic111 added a commit to atomic111/chef-os-hardening that referenced this issue Jul 18, 2016

FIX for issue #122 non-ASCII character
Signed-off-by: Patrick Münch <patrick.muench1111@gmail.com>

arlimus added a commit that referenced this issue Jul 25, 2016

Merge pull request #124 from atomic111/master
FIX for issue #122 non-ASCII character
@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Jul 25, 2016

Member

fixed with #124 @gregorkistler

can we close the issue

Member

atomic111 commented Jul 25, 2016

fixed with #124 @gregorkistler

can we close the issue

@gregorkistler

This comment has been minimized.

Show comment
Hide comment
@gregorkistler

gregorkistler Jul 25, 2016

@atomic111 yep, can be closed, thank you.

@atomic111 yep, can be closed, thank you.

rollbrettler pushed a commit to rollbrettler/chef-os-hardening that referenced this issue Sep 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment