New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of sysctl dependency #149

Merged
merged 2 commits into from Mar 29, 2017

Conversation

Projects
None yet
3 participants
@artem-sidorenko
Member

artem-sidorenko commented Mar 23, 2017

  • removal of deprecations
  • fixed the spec tests via generic stub
    (was broken on the latest sysctl versions because of native
    ruby call File.exist? in the sysctl cookbook)
  • enabling the latest sysctl cookbook versions
  • fixing the chefspec/fauxhai warnings about platform

@artem-sidorenko artem-sidorenko requested a review from chris-rock Mar 23, 2017

artem-sidorenko added some commits Mar 23, 2017

Cleanup of sysctl dependency
- removal of deprecations
- fixed the spec tests via generic stub
  (was broken on the latest sysctl versions because of native
   ruby call File.exist? in the sysctl cookbook)
- enabling the latest sysctl cookbook versions
Lets avoid chefspec/fauxhai warnings
via defining ubuntu 16.04 as default platform for spec tests
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8562a75 on attributes into c9c3a8b on master.

Coverage Status

Coverage remained the same at 100.0% when pulling 8562a75 on attributes into c9c3a8b on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8562a75 on attributes into c9c3a8b on master.

Coverage Status

Coverage remained the same at 100.0% when pulling 8562a75 on attributes into c9c3a8b on master.

@atomic111

@artem-sidorenko thanks for cleaning up the sysctl stuff

@atomic111 atomic111 merged commit e493b0f into master Mar 29, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@artem-sidorenko artem-sidorenko deleted the attributes branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment