New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the attributes with dependencies on other attributes to the recipes #150

Merged
merged 7 commits into from Mar 29, 2017

Conversation

Projects
None yet
3 participants
@artem-sidorenko
Member

artem-sidorenko commented Mar 28, 2017

See this for more details.

CI is red and should get green after #149 is merged and this PR is rebased on top

Review commit-by-commit is a good idea here

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 28, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c5d0670 on artem-sidorenko:attrs-this-time-really into c9c3a8b on dev-sec:master.

coveralls commented Mar 28, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c5d0670 on artem-sidorenko:attrs-this-time-really into c9c3a8b on dev-sec:master.

artem-sidorenko added some commits Mar 23, 2017

IP Forwarding: handle dependent attrs properly
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
IPv6 state: handle dependent attrs properly
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
ARP restrictions: handle dependent attrs properly
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
Module loading: handle dependent attrs properly
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
Magic Sysrq: handle dependent attrs properly
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
Core dumps: handle dependent attrs properly
in the recipe. Otherwise we can not really rely on the value
of dependency attribute
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 29, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 09054ee on artem-sidorenko:attrs-this-time-really into e493b0f on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 09054ee on artem-sidorenko:attrs-this-time-really into e493b0f on dev-sec:master.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Mar 29, 2017

Member

@atomic111 its rebased now :)

Member

artem-sidorenko commented Mar 29, 2017

@atomic111 its rebased now :)

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Mar 29, 2017

Member

@artem-sidorenko thanks for this great work, we get closer to 2.0

Member

atomic111 commented Mar 29, 2017

@artem-sidorenko thanks for this great work, we get closer to 2.0

@atomic111 atomic111 merged commit 65fd503 into dev-sec:master Mar 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@artem-sidorenko artem-sidorenko deleted the artem-forks:attrs-this-time-really branch Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment