New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update to ruby 2.4.1 and gem update #164

Merged
merged 4 commits into from Jun 12, 2017

Conversation

Projects
None yet
4 participants
@artem-sidorenko
Member

artem-sidorenko commented Jun 5, 2017

Chef 13 is also using ruby 2.4.1 in the omnibus packages

There are problems with Chef 13.1 in the chefspec tests. The builds are getting stucked without any specific reason. I'll investigate this further...

CI: update to ruby 2.4.1 and gem update
Chef 13 is also using ruby 2.4.1 in the omnibus packages

Signed-off-by: Artem Sidorenko <artem@posteo.de>

@alexpop alexpop added the in progress label Jun 5, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 50f3efa on ruby-2.4 into e2261fb on master.

coveralls commented Jun 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 50f3efa on ruby-2.4 into e2261fb on master.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Jun 8, 2017

Member

@chris-rock @atomic111 can somebody please have a look here? I would like to make a new release when this is merged

Member

artem-sidorenko commented Jun 8, 2017

@chris-rock @atomic111 can somebody please have a look here? I would like to make a new release when this is merged

@atomic111

@artem-sidorenko thanks for the great contribution

Show outdated Hide outdated recipes/pam.rb

artem-sidorenko added some commits Jun 2, 2017

Making rubocop happy
Signed-off-by: Artem Sidorenko <artem@posteo.de>
Making foodcritic happy
Signed-off-by: Artem Sidorenko <artem@posteo.de>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 9, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8572c05 on ruby-2.4 into e2261fb on master.

coveralls commented Jun 9, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8572c05 on ruby-2.4 into e2261fb on master.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Jun 9, 2017

Member

something is broken with NYC2 DO region: its temporary disabled by DO completely. If it is not get fixed today I'll switch our tests to the NYC3 region

Member

artem-sidorenko commented Jun 9, 2017

something is broken with NYC2 DO region: its temporary disabled by DO completely. If it is not get fixed today I'll switch our tests to the NYC3 region

Use NYC3 region for integration tests
The default NYC2 seems to be disabled on DO and is not available
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 9, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling caba6d4 on ruby-2.4 into e2261fb on master.

coveralls commented Jun 9, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling caba6d4 on ruby-2.4 into e2261fb on master.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Jun 9, 2017

Member

@atomic111 fixed now (I switched the tests to the NYC3 region)

Member

artem-sidorenko commented Jun 9, 2017

@atomic111 fixed now (I switched the tests to the NYC3 region)

@atomic111

@artem-sidorenko thanks for the update. great job!!!

@atomic111 atomic111 merged commit 2d6edc0 into master Jun 12, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@alexpop alexpop removed the in progress label Jun 12, 2017

@artem-sidorenko artem-sidorenko deleted the ruby-2.4 branch Jun 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment