New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for fedora: lets use generic package resource #176

Merged
merged 1 commit into from Oct 29, 2017

Conversation

Projects
None yet
4 participants
@artem-sidorenko
Member

artem-sidorenko commented Oct 22, 2017

On Fedora dnf is used and not yum. Lets chef decide which provider to
use

Signed-off-by: Artem Sidorenko artem@posteo.de

Fix: lets use generic package resource
On Fedora dnf is used and not yum. Lets chef decide which provider to
use

Signed-off-by: Artem Sidorenko <artem@posteo.de>

@alexpop alexpop added the in progress label Oct 22, 2017

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Oct 22, 2017

Member

@atomic111 @chris-rock can you please have a look at fedora logs? Any idea how we can fix the missing 'rsyslog' and 'auditd'? I'm not sure if we should install them

Member

artem-sidorenko commented Oct 22, 2017

@atomic111 @chris-rock can you please have a look at fedora logs? Any idea how we can fix the missing 'rsyslog' and 'auditd'? I'm not sure if we should install them

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 22, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ff3dac1 on fedora-fix into dd456fe on master.

coveralls commented Oct 22, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling ff3dac1 on fedora-fix into dd456fe on master.

@chris-rock

That is a great improvement. Thank you @artem-sidorenko

@chris-rock chris-rock merged commit ab5a27d into master Oct 29, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@chris-rock chris-rock deleted the fedora-fix branch Oct 29, 2017

@chris-rock chris-rock removed the in progress label Oct 29, 2017

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Oct 30, 2017

Member

@chris-rock thanks! But what do you think about rsyslog and audit (s. above)?

Member

artem-sidorenko commented Oct 30, 2017

@chris-rock thanks! But what do you think about rsyslog and audit (s. above)?

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 30, 2017

Member

I think we should track that in its own issue. Auditd is something we should install, since this is consistent with the other os. We may want to introduce a flag to deactivate auditd. Rsyslog only if we need it.

Member

chris-rock commented Oct 30, 2017

I think we should track that in its own issue. Auditd is something we should install, since this is consistent with the other os. We may want to introduce a flag to deactivate auditd. Rsyslog only if we need it.

@artem-sidorenko artem-sidorenko changed the title from Fix: lets use generic package resource to Fix for fedora: lets use generic package resource Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment