New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FC019: Access node attributes in a consistent manner, use single quotes #26

Merged
merged 1 commit into from May 22, 2014

Conversation

Projects
None yet
3 participants
@ehaselwanter
Contributor

ehaselwanter commented May 22, 2014

instead of symbols (project decision)

chris-rock added a commit that referenced this pull request May 22, 2014

Merge pull request #26 from ehaselwanter/master
fix FC019: Access node attributes in a consistent manner, use single quotes

@chris-rock chris-rock merged commit c1ae549 into dev-sec:master May 22, 2014

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw May 28, 2014

Contributor

So we all agree to use single quotes now?
I'm asking because I did the reverse of this commit in 8df06b1, also to fix FC019 ;-)

Contributor

bkw commented on b3515b0 May 28, 2014

So we all agree to use single quotes now?
I'm asking because I did the reverse of this commit in 8df06b1, also to fix FC019 ;-)

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock May 29, 2014

Member

Yes. We harmonized the syntax across all projects and tried to manifest it with robocop (Chef + Puppet) and foodcritic (Chef). Just use rake lint and you get your code checked.

Member

chris-rock replied May 29, 2014

Yes. We harmonized the syntax across all projects and tried to manifest it with robocop (Chef + Puppet) and foodcritic (Chef). Just use rake lint and you get your code checked.

rollbrettler pushed a commit to rollbrettler/chef-os-hardening that referenced this pull request Sep 16, 2016

Merge pull request #26 from TelekomLabs/kitchen-yml
update kitchen tests for vagrant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment