Sysctl update to 0.6.0 #46

Merged
merged 3 commits into from Sep 8, 2014

Conversation

Projects
None yet
3 participants
@arlimus
Member

arlimus commented Sep 8, 2014

Update sysctl to current release 0.6.0.
This requires an api change: including recipe "sysctl" => "sysctl:apply". This makes it incompatible with releases <0.6.0.

Thanks to @rmoriz for pointing to the outdated version in #44!

One more thing to clear: I don't know whether we should make this into a conditional, i.e. support sysctl <0.6.0 and >= 0.6.0. It's certainly possible to get the deployed cookbook version and run internals for version comparison (since chef provides methods for both).

Let's clear this before merging.

arlimus added some commits Sep 8, 2014

only fix a minimum versoin for sysctl
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
make compatible with sysctl 0.6.0
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
@rmoriz

This comment has been minimized.

Show comment
Hide comment
@rmoriz

rmoriz Sep 8, 2014

If sysctl uses semantic versioning (which I assume), it would be enough to pin to the minor release, e.g. '~> 0.6.0' which will use the latest available patch release from the 0.6.x minor-version (pessimistically greater than).
see https://docs.getchef.com/essentials_cookbook_metadata.html

rmoriz commented Sep 8, 2014

If sysctl uses semantic versioning (which I assume), it would be enough to pin to the minor release, e.g. '~> 0.6.0' which will use the latest available patch release from the 0.6.x minor-version (pessimistically greater than).
see https://docs.getchef.com/essentials_cookbook_metadata.html

@arlimus

This comment has been minimized.

Show comment
Hide comment
@arlimus

arlimus Sep 8, 2014

Member

@rmoriz Sorry, my comment was unclear: What I meant was whether this module will support older versions sysctl (ie. 0.3/0.4/0.5) and offer 0.6 as well. For this it needs to conditionally check which version of sysctl is loaded. If <0.6 is loaded, include_recipe 'sysctl', and if ~>0.6 is loaded, include_recipe 'sysctl::apply'.

We decided to do so with a deprecation warning to older versions. This will make upgrading and migrations easier for users.

I'll post the update and we'll have a version bump afterwards. Cheers

reference: https://trello.com/c/vLIoDRPM

Member

arlimus commented Sep 8, 2014

@rmoriz Sorry, my comment was unclear: What I meant was whether this module will support older versions sysctl (ie. 0.3/0.4/0.5) and offer 0.6 as well. For this it needs to conditionally check which version of sysctl is loaded. If <0.6 is loaded, include_recipe 'sysctl', and if ~>0.6 is loaded, include_recipe 'sysctl::apply'.

We decided to do so with a deprecation warning to older versions. This will make upgrading and migrations easier for users.

I'll post the update and we'll have a version bump afterwards. Cheers

reference: https://trello.com/c/vLIoDRPM

improvement: extend support for chef-sysctl from 0.3.x-0.6.x
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Sep 8, 2014

Member

cool, that looks great. Great template for our other projects.

Member

chris-rock commented Sep 8, 2014

cool, that looks great. Great template for our other projects.

chris-rock added a commit that referenced this pull request Sep 8, 2014

@chris-rock chris-rock merged commit 90915f1 into master Sep 8, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default Build #35 succeeded in 7 min 0 sec
Details

@chris-rock chris-rock deleted the sysctl-update branch Sep 8, 2014

@chris-rock chris-rock referenced this pull request Sep 8, 2014

Closed

sysctl dependency #44

@rmoriz

This comment has been minimized.

Show comment
Hide comment
@rmoriz

rmoriz Sep 8, 2014

thanks! 👍

rmoriz commented Sep 8, 2014

thanks! 👍

rollbrettler pushed a commit to rollbrettler/chef-os-hardening that referenced this pull request Sep 16, 2016

Merge pull request #46 from bkw/badges
add gymnasium badge for dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment