New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop procps service #47

Merged
merged 2 commits into from Sep 15, 2014

Conversation

Projects
None yet
2 participants
@bkw
Contributor

bkw commented Sep 14, 2014

since we now have support for sysctl::apply, we can get rid of the kludge of starting service props on every chef run.

btw: any reason why we do not just bump our dependency on the sysctl cookbook to ~> 0.6.0 and get rid of the special casing all together?

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Sep 14, 2014

Member

thanks @bkw.

We added a deprecation waring for cookbooks that use sysctl < 0.6.0. Minor releases will keep the support for the older version. Next next major release will require sysctl >= 0.6.0.

Member

chris-rock commented Sep 14, 2014

thanks @bkw.

We added a deprecation waring for cookbooks that use sysctl < 0.6.0. Minor releases will keep the support for the older version. Next next major release will require sysctl >= 0.6.0.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Sep 15, 2014

Member

I will add the documentation for sysctl 0.6.0, because this PR requires users to use sysctl::apply in their runlist.

Member

chris-rock commented Sep 15, 2014

I will add the documentation for sysctl 0.6.0, because this PR requires users to use sysctl::apply in their runlist.

chris-rock added a commit that referenced this pull request Sep 15, 2014

@chris-rock chris-rock merged commit 3bb3667 into dev-sec:master Sep 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Sep 15, 2014

Contributor

It doesn't really require that. If sysctl >= 0.6.0 is included, we include sysctl::apply anyway (see Line 29).
So only in that case, when we already do that, we don't have to restart procps again. See Line 29 of syscrl.rb.

Contributor

bkw commented Sep 15, 2014

It doesn't really require that. If sysctl >= 0.6.0 is included, we include sysctl::apply anyway (see Line 29).
So only in that case, when we already do that, we don't have to restart procps again. See Line 29 of syscrl.rb.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Sep 15, 2014

Member

I missed that. Yepp.

Member

chris-rock commented Sep 15, 2014

I missed that. Yepp.

rollbrettler pushed a commit to rollbrettler/chef-os-hardening that referenced this pull request Sep 16, 2016

Merge pull request #47 from bkw/ruby-2.13
update travis builds to ruby 2.1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment