fix SUID/SGID bit cleaning API spelling (unkown -> unknown) #72

Merged
merged 3 commits into from Jan 28, 2015

Conversation

Projects
None yet
3 participants
@dupuy
Contributor

dupuy commented Jan 28, 2015

Having a misspelling in an API is especially awkward, since fixing the spelling could break the code. But I think this is obscure enough that nobody is likely to be using it already...

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Jan 28, 2015

Member

thanks @dupuy for pointing this out!

Member

chris-rock commented Jan 28, 2015

thanks @dupuy for pointing this out!

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Jan 28, 2015

Member

@dupuy to make it complete, it would be great if you could fix it in https://github.com/TelekomLabs/chef-os-hardening/blob/master/TUTORIAL.md as well

Member

chris-rock commented Jan 28, 2015

@dupuy to make it complete, it would be great if you could fix it in https://github.com/TelekomLabs/chef-os-hardening/blob/master/TUTORIAL.md as well

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 28, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 609f726 on dupuy:api-typo into 27271de on TelekomLabs:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 609f726 on dupuy:api-typo into 27271de on TelekomLabs:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 28, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 609f726 on dupuy:api-typo into 27271de on TelekomLabs:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 609f726 on dupuy:api-typo into 27271de on TelekomLabs:master.

@dupuy

This comment has been minimized.

Show comment
Hide comment
@dupuy

dupuy Jan 28, 2015

Contributor

OK, I (re?)added the typo fix to TUTORIAL.md, and fixed a rubocop alignment error I introduced when I wrapped a long line - with the additional 2 commits, it is satisfying Travis and Coveralls.

Contributor

dupuy commented Jan 28, 2015

OK, I (re?)added the typo fix to TUTORIAL.md, and fixed a rubocop alignment error I introduced when I wrapped a long line - with the additional 2 commits, it is satisfying Travis and Coveralls.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Jan 28, 2015

Member

@dupuy great work!

Member

chris-rock commented Jan 28, 2015

@dupuy great work!

chris-rock added a commit that referenced this pull request Jan 28, 2015

Merge pull request #72 from dupuy/api-typo
fix SUID/SGID bit cleaning API spelling (unkown -> unknown)

@chris-rock chris-rock merged commit eb49def into dev-sec:master Jan 28, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@dupuy dupuy deleted the dupuy:api-typo branch Mar 18, 2015

rollbrettler pushed a commit to rollbrettler/chef-os-hardening that referenced this pull request Sep 16, 2016

Merge pull request #72 from TelekomLabs/priv-sep-sandbox
add privilege separation via sandbox mode for ssh >= 5.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment