Expose list of packages to remove as an attribute #99

Merged
merged 2 commits into from Nov 25, 2015

Conversation

Projects
None yet
2 participants
@mikemoate
Member

mikemoate commented Nov 23, 2015

This follows on from my recent pull request for #90

This exposes the list of packages to be removed by the cookbook as an attribute, with the default value of that attribute preserving the existing behaviour (i.e. creates a customisation point without a breaking change).

My primary reason for exposing this was to allow users of the cookbook to override this list should it be needed (in our specific case, we have an nagios monitoring agent that requires xinetd, which we have then taken further steps to harden) without needing to fork the cookbook.

A secondary reason is that it may make unit testing this functionality (which I am looking at for a subsequent pull request) easier.

I wasn't sure on style for README changes, so welcome any feedback.

@mikemoate

This comment has been minimized.

Show comment
Hide comment
@mikemoate

mikemoate Nov 23, 2015

Member

@Rockstar04 seemed to agree having this attribute controlled was a sensible next step. Hopefully @chris-rock was vaguely expecting this from my comments on #93 :-)

Member

mikemoate commented Nov 23, 2015

@Rockstar04 seemed to agree having this attribute controlled was a sensible next step. Hopefully @chris-rock was vaguely expecting this from my comments on #93 :-)

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Nov 24, 2015

Member

@mikemoate this is great. I like that this is configurable. Please rebase to the latest master and I will merge it!

Member

chris-rock commented Nov 24, 2015

@mikemoate this is great. I like that this is configurable. Please rebase to the latest master and I will merge it!

mikemoate and others added some commits Oct 16, 2015

Make list of packages with known issues an attribute
This gives users some flexibility to remove additional packages or keep
some of these packages if they have valid reasons, whilst preserving the
good default behaviour.
Mike Moate
Update README to document attribute for packages to remove
Document the attribute controlling the list of packages to remove,
including the default value (which preserves the existing behaviour).
@mikemoate

This comment has been minimized.

Show comment
Hide comment
@mikemoate

mikemoate Nov 24, 2015

Member

@chris-rock rebased and CI is in progress. I'm still looking at testing for this functionality, hopefully I'll find some time at the weekend.

Any thoughts on when a new version of this cookbook might be released to the supermarket?

Member

mikemoate commented Nov 24, 2015

@chris-rock rebased and CI is in progress. I'm still looking at testing for this functionality, hopefully I'll find some time at the weekend.

Any thoughts on when a new version of this cookbook might be released to the supermarket?

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Nov 25, 2015

Member

Great work @mikemoate I am going to release a new version by end of the week.

Member

chris-rock commented Nov 25, 2015

Great work @mikemoate I am going to release a new version by end of the week.

chris-rock added a commit that referenced this pull request Nov 25, 2015

Merge pull request #99 from mikemoate/packages_as_attribute
Expose list of packages to remove as an attribute

@chris-rock chris-rock merged commit 6a24b7f into dev-sec:master Nov 25, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@mikemoate mikemoate deleted the mikemoate:packages_as_attribute branch Nov 25, 2015

@rndmh3ro rndmh3ro referenced this pull request in dev-sec/ansible-os-hardening Dec 29, 2015

Merged

Packages as attributes #57

rollbrettler pushed a commit to rollbrettler/chef-os-hardening that referenced this pull request Sep 16, 2016

Merge pull request #99 from patcon/feature/x11-forwarding-config
x11 forwarding should be configurable like tcp and agent forwarding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment