New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowtcpforwarding with sftp enabled is declared twice #182

Closed
daften opened this Issue Oct 24, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@daften

daften commented Oct 24, 2017

In the template https://github.com/dev-sec/chef-ssh-hardening/blob/master/templates/default/opensshd.conf.erb if you look for allowtcpforwarding, if you enable sftp, it would be declared twice with the hardcoded value overriding the one you set

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Oct 24, 2017

Member

@daften thanks for raising this issue! You are right, AllowTcpForwarding is present in the sftp section by the end of file. From my understanding of sshd man page, the second option is part of the Match block. So it applies only to the sftp group, but not to the global section. Do I get something wrong here?

Member

artem-sidorenko commented Oct 24, 2017

@daften thanks for raising this issue! You are right, AllowTcpForwarding is present in the sftp section by the end of file. From my understanding of sshd man page, the second option is part of the Match block. So it applies only to the sftp group, but not to the global section. Do I get something wrong here?

@daften

This comment has been minimized.

Show comment
Hide comment
@daften

daften Oct 27, 2017

You are very correct @artem-sidorenko . I missed that, highlighting for files in my IDE isn't as great as i thought it seems. Thanks for the feedback.

daften commented Oct 27, 2017

You are very correct @artem-sidorenko . I missed that, highlighting for files in my IDE isn't as great as i thought it seems. Thanks for the feedback.

@daften daften closed this Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment