New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply PasswordAuthentication attribute to SSH #105

Merged
merged 2 commits into from Jan 15, 2016

Conversation

Projects
None yet
2 participants
@SteveLowe
Contributor

SteveLowe commented Dec 10, 2015

Applying the PasswordAuthentication attribute from #102 to openssh.conf.

Not sure if its best to use the same attribute, or have separate attributes for SSH and SSHD?

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Dec 23, 2015

Member

Thanks for the addition @SteveLowe I like the addition. As you mentioned already, I think we should use:

default['ssh']['client']['password_authentication']      = false   # ssh
default['ssh']['server']['password_authentication']      = false   # sshd

In addition we should add a fallback for users who use default['ssh']['password_authentication']

Member

chris-rock commented Dec 23, 2015

Thanks for the addition @SteveLowe I like the addition. As you mentioned already, I think we should use:

default['ssh']['client']['password_authentication']      = false   # ssh
default['ssh']['server']['password_authentication']      = false   # sshd

In addition we should add a fallback for users who use default['ssh']['password_authentication']

@SteveLowe

This comment has been minimized.

Show comment
Hide comment
@SteveLowe

SteveLowe Jan 4, 2016

Contributor

@chris-rock Thanks for looking at this, I have updated the PR to split client and server.

Contributor

SteveLowe commented Jan 4, 2016

@chris-rock Thanks for looking at this, I have updated the PR to split client and server.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Jan 15, 2016

Member

Hi @SteveLowe I apologize for the late response. Could you rebase to latest master? Otherwise I am not able to merge it.

Member

chris-rock commented Jan 15, 2016

Hi @SteveLowe I apologize for the late response. Could you rebase to latest master? Otherwise I am not able to merge it.

@SteveLowe

This comment has been minimized.

Show comment
Hide comment
@SteveLowe

SteveLowe Jan 15, 2016

Contributor

@chris-rock no problem, have rebased now.

Contributor

SteveLowe commented Jan 15, 2016

@chris-rock no problem, have rebased now.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Jan 15, 2016

Member

awesome. Thanks @SteveLowe

Member

chris-rock commented Jan 15, 2016

awesome. Thanks @SteveLowe

chris-rock added a commit that referenced this pull request Jan 15, 2016

Merge pull request #105 from SteveLowe/master
Apply PasswordAuthentication attribute to SSH

@chris-rock chris-rock merged commit 87dea4f into dev-sec:master Jan 15, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment