Parameterise Banner and DebianBanner as attributes #126

Merged
merged 1 commit into from Oct 24, 2016

Conversation

Projects
None yet
3 participants
@tsenart
Contributor

tsenart commented Oct 12, 2016

This commit parameterises Banner and DebianBanner in the sshd config
with the attributes ['ssh']['banner'] and ['ssh']['os_banner'] respectively,
though the latter is only supported on Debian family distributions.

Debian based distributions will have DebianBanner no set by default
from now on.

Parameterise Banner and DebianBanner as attributes
This commit parameterises `Banner` and `DebianBanner` in the sshd config
with the attributes `['ssh']['banner']` and `['ssh']['os_banner']` respectively,
though the latter is only supported on Debian family distributions.

Debian based distributions will have `DebianBanner no` set by default
from now on.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 12, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling d7491dd on tsenart:master into d204ea3 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling d7491dd on tsenart:master into d204ea3 on dev-sec:master.

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Oct 14, 2016

Member

@tsenart thanks for your PR, but there is the error with the oracle machine. Can you fix this please? Than i can merge it. if you need help let me know

Member

atomic111 commented Oct 14, 2016

@tsenart thanks for your PR, but there is the error with the oracle machine. Can you fix this please? Than i can merge it. if you need help let me know

@tsenart

This comment has been minimized.

Show comment
Hide comment
@tsenart

tsenart Oct 17, 2016

Contributor

@atomic111: I'm not sure what the issue is. Would you have any leads?

Contributor

tsenart commented Oct 17, 2016

@atomic111: I'm not sure what the issue is. Would you have any leads?

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Oct 24, 2016

Member

@tsenart this looks strange, because it is working on my local machine. i am working on this

Member

atomic111 commented Oct 24, 2016

@tsenart this looks strange, because it is working on my local machine. i am working on this

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Oct 24, 2016

Member

@tsenart I solved it. It was a little problem with travis. Thank you for the great PR

Member

atomic111 commented Oct 24, 2016

@tsenart I solved it. It was a little problem with travis. Thank you for the great PR

@atomic111 atomic111 merged commit b8f5a06 into dev-sec:master Oct 24, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

artem-sidorenko added a commit to artem-forks/chef-ssh-hardening that referenced this pull request Dec 22, 2016

artem-sidorenko added a commit to artem-forks/chef-ssh-hardening that referenced this pull request Dec 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment