New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI, Harmonization of tests, Testing of Chef 13 and Chef 12 #176

Merged
merged 3 commits into from May 16, 2017

Conversation

Projects
None yet
5 participants
@artem-sidorenko
Member

artem-sidorenko commented May 13, 2017

  • Harmonization of test and CI setup with os-hardening
  • Run tests per default on latest chef version and do some tests with Chef 12

@chris-rock @atomic111 I took a similar approach like in os-hardening, .kitchen.yml contains now vagrant setup and some parameters, .kitchen.dokken.yml contains configs for dokken/docker.

I had some problems with dokken: because of systemd thing, privileged container and some error the systemd of my host was influenced by the container process and broke. Since then I'm only using the vagrant way. I do not know your setups, but I hope this change is Okay. If not, let us discuss the alternatives

Fixes #174, #177

@alexpop alexpop added the in progress label May 13, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 14141c2 on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 14141c2 on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 14141c2 on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 14141c2 on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 73c46c5 on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 73c46c5 on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 13, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2b1bc69 on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling 2b1bc69 on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko May 13, 2017

Member

Red tests of opensuse leap should be fixed by dev-sec/ssh-baseline#88

Member

artem-sidorenko commented May 13, 2017

Red tests of opensuse leap should be fixed by dev-sec/ssh-baseline#88

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 13, 2017

Coverage Status

Coverage decreased (-0.2%) to 99.821% when pulling 76209ee on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

Coverage Status

Coverage decreased (-0.2%) to 99.821% when pulling 76209ee on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

@atomic111

@artem-sidorenko i am fine with this.

@chris-rock your opinion?

Show outdated Hide outdated .kitchen.dokken.yml
- recipe[ssh-hardening]
verifier:
inspec_tests:
- https://github.com/dev-sec/tests-ssh-hardening

This comment has been minimized.

This comment has been minimized.

@artem-sidorenko

artem-sidorenko May 15, 2017

Member

good catch, thanks! :)

@artem-sidorenko

artem-sidorenko May 15, 2017

Member

good catch, thanks! :)

Show outdated Hide outdated .kitchen.yml
@@ -78,3 +32,27 @@ suites:
verifier:
inspec_tests:
- https://github.com/dev-sec/tests-ssh-hardening

This comment has been minimized.

Show outdated Hide outdated .kitchen.yml
use_pam: false
verifier:
inspec_tests:
- https://github.com/dev-sec/tests-ssh-hardening

This comment has been minimized.

artem-sidorenko added some commits May 13, 2017

Harmonizing the CI and test setup with chef-os-hardening
- Using vagrant for kitchen tests per default
- Using dokken in the CI
- Same travis configuration structure
- Switch the tests to the latest available chef version

Signed-off-by: Artem Sidorenko <artem@posteo.de>
Enable tests on Chef 12
Signed-off-by: Artem Sidorenko <artem@posteo.de>
Support of OpenSuse Leap 42.2
Signed-off-by: Artem Sidorenko <artem@posteo.de>
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 15, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling f0e1c22 on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling f0e1c22 on artem-sidorenko:chef-13 into 3e84ded on dev-sec:master.

@chris-rock

Thank you @artem-sidorenko for this improvement

@artem-sidorenko artem-sidorenko merged commit cf0180e into dev-sec:master May 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@artem-sidorenko artem-sidorenko deleted the artem-forks:chef-13 branch May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment