New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chef Spec Tests #39

Merged
merged 6 commits into from Oct 11, 2014

Conversation

Projects
None yet
3 participants
@chris-rock
Member

chris-rock commented Sep 29, 2014

  • makes chef spec default for tests
  • add basic tests for server and client
  • bugfix permission settings
Show outdated Hide outdated spec/recipes/default_spec.rb
ChefSpec::Runner.new.converge(described_recipe)
end
# check that the recipres are executed

This comment has been minimized.

@arlimus

arlimus Sep 29, 2014

Member

tiny typo: recipes

@arlimus

arlimus Sep 29, 2014

Member

tiny typo: recipes

This comment has been minimized.

@chris-rock

chris-rock Sep 30, 2014

Member

done, thanks for finding this....

@chris-rock

chris-rock Sep 30, 2014

Member

done, thanks for finding this....

@bkw bkw referenced this pull request Oct 11, 2014

Merged

Add chef spec #43

@arlimus

This comment has been minimized.

Show comment
Hide comment
@arlimus

arlimus Oct 11, 2014

Member

Great stuff, thank you! 👍

Member

arlimus commented Oct 11, 2014

Great stuff, thank you! 👍

@arlimus

This comment has been minimized.

Show comment
Hide comment
@arlimus

arlimus Oct 11, 2014

Member

Could you please rebase? Cheers

Member

arlimus commented Oct 11, 2014

Could you please rebase? Cheers

chris-rock added some commits Sep 29, 2014

update gem file and integrate chef spec 4
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
make chef spec tests a default task
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
add chef server to spec helper and integrate coverage report
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
bugfix permission setting and add spec test
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
bugfix permission setting and add spec test for server recipe
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 11, 2014

Member

@arlimus is rebased, @bkw please rebase #43 after this has been merged

Member

chris-rock commented Oct 11, 2014

@arlimus is rebased, @bkw please rebase #43 after this has been merged

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 11, 2014

Contributor

Is rebasing really worth the hassle - given that both PRs work on the same files and for the same purpose?
I'd rather backport your improvements to the rakefile and the permission thingy into mine. I would cherry-pick where possible.

Contributor

bkw commented Oct 11, 2014

Is rebasing really worth the hassle - given that both PRs work on the same files and for the same purpose?
I'd rather backport your improvements to the rakefile and the permission thingy into mine. I would cherry-pick where possible.

@arlimus

This comment has been minimized.

Show comment
Hide comment
@arlimus

arlimus Oct 11, 2014

Member

Github didn't let me merge without rebase, sorry about that.
@chris-rock Thanks!

Member

arlimus commented Oct 11, 2014

Github didn't let me merge without rebase, sorry about that.
@chris-rock Thanks!

arlimus added a commit that referenced this pull request Oct 11, 2014

@arlimus arlimus merged commit 3799c25 into master Oct 11, 2014

1 of 2 checks passed

default Build #57 failed in 3 min 53 sec
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@arlimus arlimus deleted the chef-spec branch Oct 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment