update common Gemfile for chef11+12 #91

Merged
merged 3 commits into from May 12, 2015

Conversation

Projects
None yet
2 participants
@arlimus
Member

arlimus commented May 11, 2015

No description provided.

arlimus added some commits May 11, 2015

fix lint, support legacy
for the time being, we still have to support OS with legacy ruby, e.g. Ubuntu 12.04. So allow it to run all code correctly.

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
lint fix: disable abc for library
Unfortunately we have to disable it at this point, if we don't want to risk writing more functions to cover the same space. Even if the buildup structure of the hashmap is completely removed from these functions (thus reducing the total number of assignments considerably), we are left with a slightly over AbcSize for get_macs, which is due to the OS-checking inside. So ignore it unless we find a better solution

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>

@arlimus arlimus referenced this pull request May 12, 2015

Closed

increase robocop abc #86

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock May 12, 2015

Member

thanks for the lint improvements

Member

chris-rock commented May 12, 2015

thanks for the lint improvements

chris-rock added a commit that referenced this pull request May 12, 2015

Merge pull request #91 from hardening-io/update-common
update common Gemfile for chef11+12

@chris-rock chris-rock merged commit 21e5e95 into master May 12, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on master at 100.0%
Details

@chris-rock chris-rock deleted the update-common branch May 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment