x11 forwarding should be configurable like tcp and agent forwarding #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| X11Forwarding no | ||
| <% end %> |
There was a problem hiding this comment.
Hi @patcon what do you think about:
X11Forwarding <%= ((@node['ssh']['allow_x11_forwarding']) ? "yes" : "no" ) %>There was a problem hiding this comment.
Sure! Made other forwarding lines consistent with this too
|
Hi @patcon Thanks for this great PR. |
|
amazing. Thanks for the improvements @patcon |
chris-rock
added a commit
that referenced
this pull request
Sep 20, 2015
x11 forwarding should be configurable like tcp and agent forwarding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that the concern is similar for tcp and agent, and yet they are configurable.
If I am the only user on my server, and I'm choosing to trust it for agent forwarding, x11 forwarding should not compromise my local system to any greater degree, correct?