Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong permission on module files #175

Closed
smoeding opened this issue Jan 28, 2019 · 2 comments
Closed

Wrong permission on module files #175

smoeding opened this issue Jan 28, 2019 · 2 comments
Assignees
Labels

Comments

@smoeding
Copy link

The problem from issue #164 is still not fixed in release 2.2.0. With r10k the module is not usable as some files have restricted file permissions. This module is the only module with this behaviour.

I expect the module build process to be the root cause here. If you look into the tar file that can be downloaded from forge.puppet.com you can actually see the missing read permission for others (mode 640) for some of the files (e.g. metadata.json).

@smoeding smoeding changed the title Wrong permission on git project files Wrong permission on module files Jan 28, 2019
@mcgege mcgege self-assigned this Jan 28, 2019
@mcgege mcgege added the bug label Jan 28, 2019
@mcgege
Copy link
Member

mcgege commented Jan 28, 2019

Hmm ... as I'm working with umask of 0027, the file and directory rights for other are missing in my local repo. For the git repo, that's no problem - if you checkout the repo for yourself, the permissions will be set according to your own umask.

But for the tar file the permissions get stored as they are in my local repo (when I execute pdk build), and that seems to be a problem for r10k ...

I have now changed my Release Workflow to fix the file rights before creating the tar file. Please try out the new release ...

(will address this issue in the pdk project)

@smoeding
Copy link
Author

Looks good. The r10k deployment works now and doen't create files with restricted permissions any more.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants