Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis tests #255

Closed
mcgege opened this issue Dec 26, 2020 · 1 comment
Closed

Fix Travis tests #255

mcgege opened this issue Dec 26, 2020 · 1 comment

Comments

@mcgege
Copy link
Member

mcgege commented Dec 26, 2020

The problem was maybe? introduced with Puppet 4.19, don't know ...

Travis problem

@schurzi
Copy link
Contributor

schurzi commented Dec 30, 2020

I think I fixed that tests with #259 but there are several other issues:

  • the test for fact retrieve_system_users should also include a user, which is not a system user and conecuently is filtered by our fact
  • the test for fact home_users should not check for user names in result, but for directories.

Both issues have one underlying problem:
Our mocked users do not have a uid or a home directory. I tried several ways to inject these two attributes, but I had no success.

@schurzi schurzi closed this as completed Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants