net.ipv6.conf.default.accept_ra

[igoraj]

I just wanted to check if there is some special reason why this module only sets accept_ra on 'all', but not also on 'default'?

https://github.com/hardening-io/puppet-os-hardening/blob/master/manifests/sysctl.pp#L66-67

I can submit PR for this.

[arlimus]

Ah, great catch! One more to add to the test-suite.

Thank you @igoraj ! A PR is very welcome :)

[igoraj]

@arlimus i've checked spec/classes/sysctl_spec.rb but it seems there is no checking for net.ipv6.conf.all.accept_ra so i didn't add any for net.ipv6.conf.default.accept_ra either.

does it even make sense to put those inside as there is no ability to change them through some param?

[arlimus]

Good catch, as you said, if there's no paramter to change it (at the moment), we can leave it out of local specs.

However we run all our repos through serverspec tests, to make sure parameters are actually set at the end of everything. Looking through the code, accept_ra is an oversight there as well (which led to this issue here), so I'll add it.