Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log martian packets #66

Closed
igoraj opened this issue Jan 18, 2016 · 1 comment · Fixed by #96
Closed

Log martian packets #66

igoraj opened this issue Jan 18, 2016 · 1 comment · Fixed by #96

Comments

@igoraj
Copy link
Contributor

igoraj commented Jan 18, 2016

Not sure why this line is commented-out:
https://github.com/hardening-io/puppet-os-hardening/blob/master/manifests/sysctl.pp#L144

In chef and ansible flavors of this module it defaults to 0.
However from hardening perspective it should probably default to 1 and optionally set to 0.

Should i prepare a PR?

@atomic111
Copy link
Member

Hi @igoraj ,
yes you are correct we can remove that comment and set the default value to 0. If you set it to 1 it may cause a DoS to your system. log_martians will enable kernel logging of all received packets that have impossible source IP addresses. This could lead to massiv logging.

But you can prepare a PR. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants