Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement linux-baseline os-10 #100

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Conversation

mcgege
Copy link
Member

@mcgege mcgege commented Aug 21, 2017

Implement linux-baseline os-10 via disable_filesystems parameter
minor readme alignments

Signed-off-by: Michael Geiger michael.geiger@telekom.de

minor readme alignments

Signed-off-by: Michael Geiger <michael.geiger@telekom.de>
@mcgege
Copy link
Member Author

mcgege commented Aug 21, 2017

@bitvijays
Copy link
Contributor

Thanks @mcgege Thank you for the pull request. Really appreciated. Do you think if we create a switch for this like manage_unused_filesystems ( or something similar ), that would be better? I am just little concerned about users, who might get a little upset when vfat is blocked. mainly probably few USB Drives would stop working.

@artem-sidorenko
Copy link
Member

@bitvijays it looks like @mcgege ported my chef implementation to puppet (https://github.com/dev-sec/chef-os-hardening/pull/169/files)

@mcgege
Copy link
Member Author

mcgege commented Aug 22, 2017

@bitvijays @artem-sidorenko Of course we could add such a switch, but I think this should be consistent in all implementations ...

@mcgege
Copy link
Member Author

mcgege commented Nov 22, 2017

@artem-sidorenko @bitvijays How should we proceed here?

Copy link
Member

@artem-sidorenko artem-sidorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcgege looks good to me! Many thanks!

@artem-sidorenko artem-sidorenko merged commit fb186c0 into dev-sec:master Nov 22, 2017
@mcgege mcgege deleted the os-10 branch January 2, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants