Avoid picking up users retrieved from SSSD or other domain services. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention -- this also fixes an error caused by domain users not always having assigned UIDs: |
|
@mcgege @bitvijays as it goes into the deep of puppet, may I ask you to review it? |
|
@tprobinson many thanks for this PR! |
|
Looks good for me ... also verified the patch in my environment |
|
@tprobinson many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this module with my SSSD configuration, the fact took a really long time to resolve. Excluding users with @ in their name fixed this, as those users can't be managed by Puppet anyway.