Implement new RH defaults (see issue #102) #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Params for /etc/shadow moved to init.pp Maybe we should bring all platform parameters into one file or hiera? Signed-off-by: Michael Geiger <michael.geiger@telekom.de>
There was a problem hiding this comment.
@mcgege many thanks! looks good to me, the only question is regarding the pick function, where I can't find the docs
| } | ||
|
|
||
| # Merge defaults | ||
| $merged_umask = pick($umask, $def_umask) |
There was a problem hiding this comment.
@mcgege is the pick function something new in puppet? Could you maybe link me to the docs (I can't find them on the quick view)?
There was a problem hiding this comment.
@artem-sidorenko It's a function of stdlib: pick
artem-sidorenko
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Params for /etc/shadow moved to init.pp
Maybe we should bring all platform parameters into one file or hiera?