Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and new spec test #121

Merged
merged 4 commits into from
Feb 14, 2018
Merged

Refactoring and new spec test #121

merged 4 commits into from
Feb 14, 2018

Conversation

enemarke
Copy link
Contributor

I have moved changes in /lib/* and /manifest/* and their spec from #120 test into this pull req.

@mcgege
Copy link
Member

mcgege commented Feb 13, 2018

@enemarke I just checked out your PR in my test environment and tried it on three different systems (centos 7, opensuse 42.3, ubuntu 16.04 / puppet version 5.3.3) - on all systems I get an error:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER:
Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error:
Unknown function: 'combine_sugid_lists'. at [...]/os_hardening/manifests/suid_sgid.pp:114:22 on node

@enemarke
Copy link
Contributor Author

Sorry my mistake. In this branch I forgot to move the function to the correct folder. That should now be fixed.

@mcgege
Copy link
Member

mcgege commented Feb 14, 2018

Looks good now, thank you!

@mcgege mcgege merged commit 2913f67 into dev-sec:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants